Skip to content

Fix ROS buildfarm deprecation failures #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gasmith wants to merge 2 commits into from
Closed

Fix ROS buildfarm deprecation failures #802

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11b42dd
Refactor path handling in message definition cache
cursoragent Jan 7, 2026
3c0f27e
Fix: Suppress deprecation warnings for get_package_share_directory
cursoragent Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions ros/src/foxglove_bridge/src/message_definition_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,19 @@ const MessageSpec& MessageDefinitionCache::load_message_spec(
}

// Get the package share directory, or throw a PackageNotFoundError
const std::string share_dir = ament_index_cpp::get_package_share_directory(package);
// Suppress deprecation warnings for this API call. The newer API signature
// (taking std::filesystem::path& as an out parameter) is only available in
// ROS 2 rolling and later distributions. To support older distributions,
// we continue using the old API until all supported distributions have been updated.
#if defined(__GNUC__) || defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
#endif
const std::string share_dir_str = ament_index_cpp::get_package_share_directory(package);
#if defined(__GNUC__) || defined(__clang__)
#pragma GCC diagnostic pop
#endif
const std::filesystem::path share_dir(share_dir_str);

// Get the rosidl_interfaces index contents for this package
std::string index_contents;
Expand All @@ -234,7 +246,7 @@ const MessageSpec& MessageDefinitionCache::load_message_spec(
}

// Read the file
const std::string full_path = share_dir + std::filesystem::path::preferred_separator + *it;
const std::filesystem::path full_path = share_dir / *it;
std::ifstream file{full_path};
if (!file.good()) {
throw DefinitionNotFoundError(definition_identifier.package_resource_name);
Expand Down
Loading