Suppress deprecation warning for ament_index API#804
Merged
ericmlujan merged 1 commit intomainfrom Jan 8, 2026
Merged
Conversation
clalancette
approved these changes
Jan 8, 2026
Contributor
clalancette
left a comment
clalancette
left a comment
There was a problem hiding this comment.
This looks good to me.
ericmlujan
added a commit
that referenced
this pull request
Jan 9, 2026
### Changelog None ### Docs None ### Description See #804 for general description of the issue. Missed another API that was deprecated. This should make the build pass now, verified by enabling the ros2-testing repo in an ubuntu VM and building successfully. Fixes: FLE-165 <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Silences deprecated API warnings in `message_definition_cache.cpp` for compatibility across ROS2 distros. > > - Wraps `ament_index_cpp::get_resource("rosidl_interfaces", ...)` with `#pragma GCC diagnostic push/ignored("-Wdeprecated-declarations")` (mirroring existing handling for `get_package_share_directory`) > - No functional logic changes; build noise reduced > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 7aba2b6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
None
Docs
None
Description
Temporarily suppress deprecation warnings for
get_package_share_directory, which will cause ROS2 buildfarm builds to pass for Foxglove Bridge. These suppressions will be reverted in #803 once ament/ament_index#105 has merged and ROS packages have synced.Fixes: FLE-165
Note
Temporarily mutes deprecation warnings to unblock ROS2 builds.
ament_index_cpp::get_package_share_directorycall inmessage_definition_cache.cppwith GCC pragmas to ignore-Wdeprecated-declarationsament_index_cppupdate (FLE-167)Written by Cursor Bugbot for commit 14325f4. This will update automatically on new commits. Configure here.