Fix gazebo joint collision check bug #227
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickstaa
force-pushed
the
fix_gazebo_joint_collision_check_bug
branch
from
a07f15e to
78ab3e7
Compare
rickstaa
commented
Feb 22, 2022
rickstaa
force-pushed
the
fix_gazebo_joint_collision_check_bug
branch
2 times, most recently
from
2607036 to
c3bb941
Compare
2 tasks
rickstaa
force-pushed
the
fix_gazebo_joint_collision_check_bug
branch
from
c3bb941 to
ee0ad7d
Compare
Contributor
Author
|
@Maverobot, @gollth, since I still think this pull request fixes a critical bug, I just rebased it on the Your assistance in getting this pull request merged would be significantly appreciated 🙏🏻. Thanks a lot in advance! |
gollth
approved these changes
Sep 4, 2023
Contributor
gollth
left a comment
gollth
left a comment
There was a problem hiding this comment.
Thanks for finding this. Makes sense to me!
5 tasks
This commit makes sure the gravity contribution is accounted for in the joint collision checking. This needs to be done since it is not stored in `joint->command` variable.
rickstaa
force-pushed
the
fix_gazebo_joint_collision_check_bug
branch
from
ee0ad7d to
e0ffbf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request ensures the gravity contribution is accounted for in the joint collision checking. This needs to be done since it is not stored in
joint->commandvariable. Please have a look at #363 for more information.