Skip to content

Conversation

@traversaro
Copy link

@traversaro traversaro commented Aug 2, 2025

The rclcpp_action dependency was added in the CMake in 4a001fc#diff-f4465f78e3e87470bb5d2b22df0aa00dcc3a48b8f63c24feac83b9ca1074a2f5, but the dependency was not added in the package.xml .

Similarly, the rclcpp_components dependency was added in eae138a#diff-f4465f78e3e87470bb5d2b22df0aa00dcc3a48b8f63c24feac83b9ca1074a2f5, but it was not added in package.xml .

@traversaro traversaro changed the title franka_hardware: Add missing rclcpp_action dependency in package.xml franka_hardware: Add missing rclcpp_action and rclcpp_components dependencies in package.xml Aug 2, 2025
@traversaro
Copy link
Author

Related PR: #96 .

I did not opened new PRs, but just for reference these are the whole dependencies that were missing according to our analysis:

franka_hardware:
  add_host: ["ros-humble-rclcpp-action", "ros-humble-rclcpp-components"]
  add_run: ["ros-humble-rclcpp-action",  "ros-humble-rclcpp-components"]
franka_semantic_components:
  add_host: ["ros-humble-urdf", "ros-humble-controller-interface"]
  add_run: ["ros-humble-urdf", "ros-humble-controller-interface"]
franka_robot_state_broadcaster:
  add_host: ["ros-humble-visualization-msgs"]
  add_run: ["ros-humble-visualization-msgs"]
franka_example_controllers:
  add_host: ["ros-humble-moveit-core"]
  add_run: ["ros-humble-moveit-core"]
franka_ign_ros2_control:
  add_host: ["ros-humble-urdf", "ros-humble-kdl-parser", "ros-humble-tf2-geometry-msgs", "ros-humble-tf2-eigen", "${{ 'libgl-devel' if linux }}"]
  add_run: ["ros-humble-urdf", "ros-humble-kdl-parser", "ros-humble-tf2-geometry-msgs", "ros-humble-tf2-eigen"]

If you are interested, we can open dedicated PR for each, or a PR with all the missing dependencies.

@AndreasKuhner
Copy link
Member

Hi @traversaro , yes, maybe a all-in-one PR would be nice... less PRs means less testing on our side xd

(we are anyways 'a bit' behind for all of this testing...)

Cheers,
Andreas

@traversaro
Copy link
Author

Hi @traversaro , yes, maybe a all-in-one PR would be nice... less PRs means less testing on our side xd

(we are anyways 'a bit' behind for all of this testing...)

Cheers,
Andreas

Ok, I will prepare it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants