Skip to content

fix(accounts): retain payment request on advance allocation (backport #64511) - #64627

Merged
mergify[bot] merged 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-64511
Nov 10, 2026
Merged

mergify[bot] merged 1 commit into
version-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-64511

Conversation

@mergify

@mergify mergify Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Issue

  • When an advance Payment Entry is allocated to a Sales Invoice, the Payment Request link can be lost from the Payment Entry references. Cancelling the Payment Entry then leaves the Payment Request marked Paid with zero outstanding, even though the invoice is unpaid.

Closes #64341.

Steps to replicate

  • Submit a Sales Order for 100.
  • Create and submit a Payment Request from the Sales Order.
  • Create a Payment Entry from the Payment Request and submit it.
  • Create a Sales Invoice from the Sales Order, enable automatic FIFO advance allocation, and submit the invoice.
  • Cancel the Payment Entry.

Actual behavior

  • The Payment Request remains Paid with zero outstanding after cancellation, while the Sales Invoice becomes unpaid.

Expected behavior

@mergify

mergify Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Queue requested — the merge queue status continues in this comment ↓.

@Pandiyan5273
Pandiyan5273 force-pushed the mergify/bp/version-16-hotfix/pr-64511 branch 2 times, most recently from 3cc691a to aa335c0 Compare November 10, 2026 07:12
@Pandiyan5273

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Merged into version-16-hotfix as 1fc5a94 at 07:55 UTC

Merged together with #64260, #64573. 38 min in the queue, 27 min of it CI.

So far

3 merge conditions met
  • #review-threads-unresolved = 0 · required by GitHub branch protection
  • github-review-approved · required by GitHub branch protection
  • any of:
    • all of:
      • check-success=Patch Test
      • check-success=Python Unit Tests (1)
      • check-success=Python Unit Tests (2)
      • check-success=Python Unit Tests (3)
      • check-success=Python Unit Tests (4)
    • -files~=^(?!erpnext/locale/main\.pot$)

Times in UTC · dashboard · how the merge queue works

@Pandiyan5273

Copy link
Copy Markdown
Member

@Mergifyio queue

@mergify

mergify Bot commented Nov 10, 2026

Copy link
Copy Markdown
Contributor Author

queue

☑️ Command queue ignored because it is already running from a previous command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant