Skip to content

fix: default permission for HR roles (backport #4264)#4407

Merged
iamkhanraheel merged 12 commits intoversion-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4264
Apr 20, 2026
Merged

fix: default permission for HR roles (backport #4264)#4407
iamkhanraheel merged 12 commits intoversion-16-hotfixfrom
mergify/bp/version-16-hotfix/pr-4264

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Apr 17, 2026

Reason

Inconsistent default permissions led to incomplete access for HR Manager & HR User roles preventing them from properly using reports, dashboards, and linked doctypes.
image

Changes done

  • Added missing default role permissions accross HR modules to ensure proper access to reports, dashboards and linked doctypes

erpnext pr: frappe/erpnext#53756

Role permission for:

  • HR User
  • HR Manager

Closes: #810

Summary by CodeRabbit

  • New Features

    • Expanded role-based access: many HR and Payroll records, reports and dashboards now grant explicit HR Manager and HR User permissions.
    • Dashboard charts: explicit role access plus an option to show values over charts.
  • Chores

    • Enabled dynamic row formatting across multiple forms; normalized file/report/workspace layouts.
    • Installer now seeds default HR permissions during setup.

This is an automatic backport of pull request #4264 done by [Mergify](https://mergify.com).

(cherry picked from commit 3e9fee7)

# Conflicts:
#	hrms/hr/doctype/job_opening_template/job_opening_template.json
…doctypes in frappe app

(cherry picked from commit c6e46fc)

# Conflicts:
#	hrms/hr/doctype/job_applicant/job_applicant.json
#	hrms/hr/doctype/job_opening/job_opening.json
#	hrms/hr/doctype/job_opening_template/job_opening_template.json
#	hrms/setup.py
(cherry picked from commit 4a8fff8)

# Conflicts:
#	hrms/setup.py
(cherry picked from commit 4ad1dec)

# Conflicts:
#	hrms/hr/doctype/job_opening_template/job_opening_template.json
(cherry picked from commit 3e8274a)

# Conflicts:
#	hrms/setup.py
… docperm

(cherry picked from commit 37158b6)

# Conflicts:
#	hrms/setup.py
(cherry picked from commit 739fdfb)

# Conflicts:
#	hrms/patches.txt
(cherry picked from commit 44ca81e)

# Conflicts:
#	hrms/hr/doctype/job_opening_template/job_opening_template.json
…post Accounting Ledger Settings is merged into accounts settings

(cherry picked from commit af99a2f)

# Conflicts:
#	hrms/hr/doctype/expense_claim/test_expense_claim.py
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Apr 17, 2026

Cherry-pick of 3e9fee7 has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is up to date with 'origin/version-16-hotfix'.

You are currently cherry-picking commit 3e9fee70.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hr/doctype/employee_onboarding/employee_onboarding.json
	modified:   hrms/hr/doctype/employee_onboarding_template/employee_onboarding_template.json
	modified:   hrms/hr/doctype/employee_skill_map/employee_skill_map.json
	modified:   hrms/hr/doctype/exit_interview/exit_interview.json
	modified:   hrms/hr/doctype/expense_claim_type/expense_claim_type.json
	modified:   hrms/hr/doctype/job_offer_term_template/job_offer_term_template.json
	modified:   hrms/hr/doctype/job_requisition/job_requisition.json
	modified:   hrms/hr/doctype/overtime_type/overtime_type.json
	modified:   hrms/hr/doctype/skill/skill.json
	modified:   hrms/hr/doctype/training_event/training_event.json
	modified:   hrms/hr/doctype/training_feedback/training_feedback.json
	modified:   hrms/hr/doctype/training_program/training_program.json
	modified:   hrms/hr/doctype/training_result/training_result.json
	modified:   hrms/payroll/doctype/employee_benefit_ledger/employee_benefit_ledger.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/job_opening_template/job_opening_template.json

Cherry-pick of c6e46fc has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 1 commit.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit c6e46fc0.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hr/dashboard_chart/appraisal_overview/appraisal_overview.json
	modified:   hrms/hr/dashboard_chart/claims_by_type/claims_by_type.json
	modified:   hrms/hr/dashboard_chart/employees_by_age/employees_by_age.json
	modified:   hrms/hr/dashboard_chart/hiring_vs_attrition_count/hiring_vs_attrition_count.json
	modified:   hrms/hr/doctype/job_applicant_source/job_applicant_source.json
	modified:   hrms/hr/doctype/job_offer/job_offer.json
	modified:   hrms/hr/doctype/job_requisition/job_requisition.json
	modified:   hrms/hr/doctype/kra/kra.json
	modified:   hrms/hr/doctype/leave_block_list/leave_block_list.json
	modified:   hrms/hr/doctype/leave_control_panel/leave_control_panel.json
	modified:   hrms/hr/doctype/offer_term/offer_term.json
	modified:   hrms/hr/report/daily_work_summary_replies/daily_work_summary_replies.json
	modified:   hrms/hr/workspace/expenses/expenses.json
	modified:   hrms/payroll/doctype/additional_salary/additional_salary.json
	modified:   hrms/payroll/doctype/bulk_salary_structure_assignment/bulk_salary_structure_assignment.json
	modified:   hrms/payroll/doctype/payroll_settings/payroll_settings.json
	modified:   hrms/payroll/doctype/salary_component/salary_component.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/job_applicant/job_applicant.json
	both modified:   hrms/hr/doctype/job_opening/job_opening.json
	both modified:   hrms/hr/doctype/job_opening_template/job_opening_template.json
	both modified:   hrms/setup.py

Cherry-pick of 4a8fff8 has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 2 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 4a8fff88.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hr/doctype/daily_work_summary/daily_work_summary.json
	modified:   hrms/hr/doctype/employee_onboarding_template/employee_onboarding_template.json
	modified:   hrms/hr/doctype/employee_separation/employee_separation.json
	modified:   hrms/hr/doctype/employee_separation_template/employee_separation_template.json
	modified:   hrms/hr/doctype/employee_skill_map/employee_skill_map.json
	modified:   hrms/hr/doctype/exit_interview/exit_interview.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/setup.py

Cherry-pick of 4ad1dec has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 3 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 4ad1deca.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hr/dashboard_chart/timesheet_activity_breakup/timesheet_activity_breakup.json
	modified:   hrms/hr/doctype/job_applicant_source/job_applicant_source.json
	modified:   hrms/hr/doctype/job_offer/job_offer.json
	modified:   hrms/hr/doctype/job_offer_term/job_offer_term.json
	modified:   hrms/hr/doctype/job_requisition/job_requisition.json
	modified:   hrms/hr/doctype/kra/kra.json
	modified:   hrms/hr/doctype/offer_term/offer_term.json
	modified:   hrms/hr/doctype/overtime_type/overtime_type.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/job_opening_template/job_opening_template.json

Cherry-pick of 3e8274a has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 4 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 3e8274a8.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/setup.py

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 37158b6 has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 5 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 37158b65.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/setup.py

no changes added to commit (use "git add" and/or "git commit -a")

Cherry-pick of 739fdfb has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 6 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 739fdfb5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   hrms/patches/v16_0/add_default_hr_role_permissions.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/patches.txt

Cherry-pick of 44ca81e has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 7 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit 44ca81e2.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   hrms/hr/doctype/daily_work_summary/daily_work_summary.json
	modified:   hrms/hr/doctype/employee_separation/employee_separation.json
	modified:   hrms/hr/doctype/exit_interview/exit_interview.json
	modified:   hrms/hr/doctype/expense_claim_type/expense_claim_type.json
	modified:   hrms/hr/doctype/job_applicant_source/job_applicant_source.json
	modified:   hrms/hr/doctype/job_offer_term_template/job_offer_term_template.json

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/job_opening_template/job_opening_template.json

Cherry-pick of af99a2f has failed:

On branch mergify/bp/version-16-hotfix/pr-4264
Your branch is ahead of 'origin/version-16-hotfix' by 8 commits.
  (use "git push" to publish your local commits)

You are currently cherry-picking commit af99a2f9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   hrms/hr/doctype/expense_claim/test_expense_claim.py

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@iamkhanraheel iamkhanraheel force-pushed the mergify/bp/version-16-hotfix/pr-4264 branch from 3512261 to 0838414 Compare April 17, 2026 07:36
@iamkhanraheel iamkhanraheel force-pushed the mergify/bp/version-16-hotfix/pr-4264 branch from 0838414 to ec87dc1 Compare April 17, 2026 07:44
@iamkhanraheel iamkhanraheel enabled auto-merge (rebase) April 20, 2026 05:50
@iamkhanraheel iamkhanraheel merged commit 273c924 into version-16-hotfix Apr 20, 2026
10 checks passed
@iamkhanraheel iamkhanraheel deleted the mergify/bp/version-16-hotfix/pr-4264 branch April 20, 2026 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants