fix: default permission for HR roles (backport #4264)#4407
Merged
iamkhanraheel merged 12 commits intoversion-16-hotfixfrom Apr 20, 2026
Merged
fix: default permission for HR roles (backport #4264)#4407iamkhanraheel merged 12 commits intoversion-16-hotfixfrom
iamkhanraheel merged 12 commits intoversion-16-hotfixfrom
Conversation
(cherry picked from commit 3e9fee7) # Conflicts: # hrms/hr/doctype/job_opening_template/job_opening_template.json
…doctypes in frappe app (cherry picked from commit c6e46fc) # Conflicts: # hrms/hr/doctype/job_applicant/job_applicant.json # hrms/hr/doctype/job_opening/job_opening.json # hrms/hr/doctype/job_opening_template/job_opening_template.json # hrms/setup.py
(cherry picked from commit 4a8fff8) # Conflicts: # hrms/setup.py
(cherry picked from commit 4ad1dec) # Conflicts: # hrms/hr/doctype/job_opening_template/job_opening_template.json
(cherry picked from commit 3e8274a) # Conflicts: # hrms/setup.py
… docperm (cherry picked from commit 37158b6) # Conflicts: # hrms/setup.py
(cherry picked from commit 739fdfb) # Conflicts: # hrms/patches.txt
(cherry picked from commit 44ca81e) # Conflicts: # hrms/hr/doctype/job_opening_template/job_opening_template.json
…post Accounting Ledger Settings is merged into accounts settings (cherry picked from commit af99a2f) # Conflicts: # hrms/hr/doctype/expense_claim/test_expense_claim.py
(cherry picked from commit a712930)
Contributor
Author
|
Cherry-pick of 3e9fee7 has failed: Cherry-pick of c6e46fc has failed: Cherry-pick of 4a8fff8 has failed: Cherry-pick of 4ad1dec has failed: Cherry-pick of 3e8274a has failed: Cherry-pick of 37158b6 has failed: Cherry-pick of 739fdfb has failed: Cherry-pick of 44ca81e has failed: Cherry-pick of af99a2f has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
3512261 to
0838414
Compare
0838414 to
ec87dc1
Compare
deepeshgarg007
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason
Inconsistent default permissions led to incomplete access for HR Manager & HR User roles preventing them from properly using reports, dashboards, and linked doctypes.

Changes done
erpnext pr: frappe/erpnext#53756
Role permission for:
Closes: #810
Summary by CodeRabbit
New Features
Chores
This is an automatic backport of pull request #4264 done by [Mergify](https://mergify.com).