Skip to content

fix: default permission for HR roles (backport #4264) #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamkhanraheel merged 12 commits into from
Apr 20, 2026
Merged

fix: default permission for HR roles (backport #4264) #4407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
df64f86
fix: default permission for HR User role
iamkhanraheel Mar 24, 2026
fa37fb8
fix: default permission for HR manager role & add custom docperm for …
iamkhanraheel Mar 26, 2026
53ee7f8
fix: default perm for HR manager & HR user
iamkhanraheel Apr 7, 2026
9dcd937
fix: deault perm for HR manager & HR user
iamkhanraheel Apr 9, 2026
c191b0e
fix: remove unwanted import
iamkhanraheel Apr 9, 2026
f0ee3ac
fix: add update_permission_property to update perm in existing custom…
iamkhanraheel Apr 9, 2026
fca9cd0
patch: add default HR roles permissions
iamkhanraheel Apr 10, 2026
8708fb9
fix: add default perms for HR user & remove unnecessary perms
iamkhanraheel Apr 16, 2026
abbbda5
test(expense_claim): add repost doctype in repost_allowed_types as Re…
iamkhanraheel Apr 16, 2026
9fd8265
fix: remove unnecessary access for manufacturing & account user roles
iamkhanraheel Apr 16, 2026
ec87dc1
fix: conflicts
iamkhanraheel Apr 17, 2026
30b5c51
Merge branch 'version-16-hotfix' into mergify/bp/version-16-hotfix/pr…
iamkhanraheel Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions hrms/hr/dashboard_chart/appraisal_overview/appraisal_overview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,29 @@
"idx": 0,
"is_public": 0,
"is_standard": 1,
"modified": "2026-01-10 15:16:33.659637",
"modified": "2026-03-26 15:50:08.184379",
"modified_by": "Administrator",
"module": "HR",
"name": "Appraisal Overview",
"number_of_groups": 0,
"owner": "Administrator",
"report_name": "Appraisal Overview",
"roles": [
{}
{
"role": "System Manager"
},
{
"role": "HR Manager"
},
{
"role": "HR User"
},
{
"role": "Employee Self Service"
},
{
"role": "Employee"
}
],
"show_values_over_chart": 0,
"time_interval": "Yearly",
Expand Down
21 changes: 16 additions & 5 deletions hrms/hr/dashboard_chart/claims_by_type/claims_by_type.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"based_on": "",
"chart_name": "Claims by Type",
"chart_type": "Group By",
"creation": "2022-08-31 23:04:43.377345",
"creation": "2025-07-15 13:15:12.796881",
"docstatus": 0,
"doctype": "Dashboard Chart",
"document_type": "Expense Claim Detail",
Expand All @@ -13,15 +13,26 @@
"idx": 0,
"is_public": 1,
"is_standard": 1,
"last_synced_on": "2022-09-16 11:36:29.484579",
"modified": "2022-09-16 11:39:08.205987",
"last_synced_on": "2026-03-26 15:47:23.289876",
"modified": "2026-03-26 15:47:44.955110",
"modified_by": "Administrator",
"module": "HR",
"name": "Claims by Type",
"number_of_groups": 0,
"owner": "Administrator",
"parent_document_type": "Expense Claim",
"roles": [],
"roles": [
{
"role": "System Manager"
},
{
"role": "HR Manager"
},
{
"role": "HR User"
}
],
"show_values_over_chart": 0,
"source": "",
"time_interval": "Yearly",
"timeseries": 0,
Expand All @@ -30,4 +41,4 @@
"use_report_chart": 0,
"value_based_on": "",
"y_axis": []
}
}
21 changes: 16 additions & 5 deletions hrms/hr/dashboard_chart/employees_by_age/employees_by_age.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"based_on": "",
"chart_name": "Employees by Age",
"chart_type": "Custom",
"creation": "2022-08-22 19:07:51.906347",
"creation": "2025-07-15 13:15:12.774524",
"custom_options": "{\n\t\"colors\": [\"#7cd6fd\"],\n\t\"barOptions\": {\"spaceRatio\": 0.5}\n}",
"docstatus": 0,
"doctype": "Dashboard Chart",
Expand All @@ -13,15 +13,26 @@
"idx": 0,
"is_public": 1,
"is_standard": 1,
"last_synced_on": "2022-08-22 19:00:02.464180",
"modified": "2022-08-22 19:11:20.076166",
"last_synced_on": "2026-03-26 15:46:28.262525",
"modified": "2026-03-26 15:46:47.145092",
"modified_by": "Administrator",
"module": "HR",
"name": "Employees by Age",
"number_of_groups": 0,
"owner": "Administrator",
"parent_document_type": "",
"roles": [],
"roles": [
{
"role": "System Manager"
},
{
"role": "HR Manager"
},
{
"role": "HR User"
}
],
"show_values_over_chart": 0,
"source": "Employees by Age",
"time_interval": "Yearly",
"timeseries": 0,
Expand All @@ -30,4 +41,4 @@
"use_report_chart": 0,
"value_based_on": "",
"y_axis": []
}
}
21 changes: 16 additions & 5 deletions hrms/hr/dashboard_chart/hiring_vs_attrition_count/hiring_vs_attrition_count.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"based_on": "",
"chart_name": "Hiring vs Attrition Count",
"chart_type": "Custom",
"creation": "2022-08-21 22:58:12.740936",
"creation": "2025-07-15 13:15:12.786726",
"custom_options": "{\n\t\"type\": \"axis-mixed\",\n\t\"axisOptions\": {\n\t\t\"xIsSeries\": 1\n\t},\n\t\"lineOptions\": {\n\t \"regionFill\": 1\n\t},\n\t\"colors\": [\"#7cd6fd\", \"#5e64ff\"]\n}",
"docstatus": 0,
"doctype": "Dashboard Chart",
Expand All @@ -13,15 +13,26 @@
"idx": 0,
"is_public": 1,
"is_standard": 1,
"last_synced_on": "2022-08-22 10:57:55.011020",
"modified": "2022-08-22 11:03:30.080835",
"last_synced_on": "2026-03-26 15:45:20.553274",
"modified": "2026-03-26 15:46:19.045676",
"modified_by": "Administrator",
"module": "HR",
"name": "Hiring vs Attrition Count",
"number_of_groups": 0,
"owner": "Administrator",
"parent_document_type": "",
"roles": [],
"roles": [
{
"role": "System Manager"
},
{
"role": "HR Manager"
},
{
"role": "HR User"
}
],
"show_values_over_chart": 0,
"source": "Hiring vs Attrition Count",
"time_interval": "Yearly",
"timeseries": 0,
Expand All @@ -30,4 +41,4 @@
"use_report_chart": 0,
"value_based_on": "",
"y_axis": []
}
}
24 changes: 19 additions & 5 deletions hrms/hr/dashboard_chart/timesheet_activity_breakup/timesheet_activity_breakup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"based_on": "",
"chart_name": "Timesheet Activity Breakup",
"chart_type": "Group By",
"creation": "2022-08-21 14:31:10.401241",
"creation": "2025-07-15 13:15:12.817847",
"docstatus": 0,
"doctype": "Dashboard Chart",
"document_type": "Timesheet Detail",
Expand All @@ -14,15 +14,29 @@
"idx": 0,
"is_public": 1,
"is_standard": 1,
"last_synced_on": "2022-08-21 17:55:44.318686",
"modified": "2022-08-21 17:59:38.576219",
"last_synced_on": "2026-04-16 17:14:16.020107",
"modified": "2026-04-16 17:18:58.677457",
"modified_by": "Administrator",
"module": "HR",
"name": "Timesheet Activity Breakup",
"number_of_groups": 0,
"owner": "Administrator",
"parent_document_type": "Timesheet",
"roles": [],
"roles": [
{
"role": "System Manager"
},
{
"role": "HR Manager"
},
{
"role": "HR User"
},
{
"role": "Employee"
}
],
"show_values_over_chart": 0,
"source": "",
"time_interval": "Yearly",
"timeseries": 0,
Expand All @@ -31,4 +45,4 @@
"use_report_chart": 0,
"value_based_on": "",
"y_axis": []
}
}
15 changes: 8 additions & 7 deletions hrms/hr/doctype/daily_work_summary/daily_work_summary.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
],
"in_create": 1,
"links": [],
"modified": "2024-09-18 13:30:28.136511",
"modified": "2026-04-16 12:52:47.429304",
"modified_by": "Administrator",
"module": "HR",
"name": "Daily Work Summary",
Expand All @@ -46,19 +46,20 @@
"read": 1,
"role": "Employee"
},
{
"read": 1,
"role": "HR User"
},
{
"delete": 1,
"email": 1,
"export": 1,
"print": 1,
"read": 1,
"report": 1,
"role": "HR User",
"share": 1
"role": "HR Manager"
}
],
"quick_entry": 1,
"row_format": "Dynamic",
"sort_field": "creation",
"sort_order": "DESC",
"states": []
}
}
9 changes: 8 additions & 1 deletion hrms/hr/doctype/employee_onboarding/employee_onboarding.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@
],
"is_submittable": 1,
"links": [],
"modified": "2026-02-05 13:46:25.874832",
"modified": "2026-03-24 17:13:19.990319",
"modified_by": "Administrator",
"module": "HR",
"name": "Employee Onboarding",
Expand Down Expand Up @@ -207,6 +207,13 @@
"share": 1,
"submit": 1,
"write": 1
},
{
"create": 1,
"read": 1,
"report": 1,
"role": "HR User",
"write": 1
}
],
"row_format": "Dynamic",
Expand Down
21 changes: 19 additions & 2 deletions hrms/hr/doctype/employee_onboarding_template/employee_onboarding_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}
],
"links": [],
"modified": "2024-03-27 13:09:40.119200",
"modified": "2026-04-07 17:54:37.020259",
"modified_by": "Administrator",
"module": "HR",
"name": "Employee Onboarding Template",
Expand All @@ -85,12 +85,29 @@
"role": "System Manager",
"share": 1,
"write": 1
},
{
"create": 1,
"read": 1,
"report": 1,
"role": "HR User",
"write": 1
},
{
"create": 1,
"delete": 1,
"export": 1,
"read": 1,
"report": 1,
"role": "HR Manager",
"write": 1
}
],
"row_format": "Dynamic",
"show_title_field_in_link": 1,
"sort_field": "creation",
"sort_order": "DESC",
"states": [],
"title_field": "title",
"track_changes": 1
}
}
18 changes: 16 additions & 2 deletions hrms/hr/doctype/employee_separation/employee_separation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@
],
"is_submittable": 1,
"links": [],
"modified": "2024-03-27 13:09:41.099448",
"modified": "2026-04-16 14:24:20.502402",
"modified_by": "Administrator",
"module": "HR",
"name": "Employee Separation",
Expand All @@ -175,12 +175,26 @@
"share": 1,
"submit": 1,
"write": 1
},
{
"create": 1,
"read": 1,
"report": 1,
"role": "HR Manager",
"write": 1
},
{
"create": 1,
"read": 1,
"role": "HR User",
"write": 1
}
],
"quick_entry": 1,
"row_format": "Dynamic",
"sort_field": "creation",
"sort_order": "DESC",
"states": [],
"title_field": "employee_name",
"track_changes": 1
}
}
16 changes: 14 additions & 2 deletions hrms/hr/doctype/employee_separation_template/employee_separation_template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
}
],
"links": [],
"modified": "2024-03-27 13:09:41.257092",
"modified": "2026-04-07 18:18:38.087000",
"modified_by": "Administrator",
"module": "HR",
"name": "Employee Separation Template",
Expand All @@ -85,12 +85,24 @@
"role": "System Manager",
"share": 1,
"write": 1
},
{
"create": 1,
"delete": 1,
"read": 1,
"role": "HR Manager",
"write": 1
},
{
"read": 1,
"role": "HR User"
}
],
"row_format": "Dynamic",
"show_title_field_in_link": 1,
"sort_field": "creation",
"sort_order": "DESC",
"states": [],
"title_field": "title",
"track_changes": 1
}
}
Loading
Loading