Skip to content

refactor: remove sass dependency#752

Merged
nextchamp-saqib merged 8 commits intofrappe:developfrom
ishanloya:remove-sass
Apr 6, 2026
Merged

refactor: remove sass dependency#752
nextchamp-saqib merged 8 commits intofrappe:developfrom
ishanloya:remove-sass

Conversation

@ishanloya
Copy link
Copy Markdown
Contributor

SASS is only being used for CSS nesting which has baseline support since 2023. The legacy SASS API is deprecated and was leading to warnings in the terminal. The warnings were suppressed in #745.

ishanloya and others added 8 commits January 10, 2026 14:20
Attempt to fix the following warnings:
Deprecation Warning [legacy-js-api]: The legacy JS API is deprecated and will be removed in Dart Sass 2.0.0.
- Remove sass package from devDependencies
- Convert all Vue component style tags from SCSS to native CSS
- Use modern CSS nesting (& selector) for cleaner styles
- Update 8 Vue components across src/ and src2/ directories
- Build verified successfully without SASS preprocessor
@nextchamp-saqib nextchamp-saqib changed the title Remove sass dependency refactor: remove sass dependency Apr 6, 2026
@nextchamp-saqib nextchamp-saqib merged commit 8aaa08e into frappe:develop Apr 6, 2026
2 checks passed
mergify bot pushed a commit that referenced this pull request Apr 6, 2026
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
(cherry picked from commit 8aaa08e)
nextchamp-saqib added a commit that referenced this pull request Apr 6, 2026
(cherry picked from commit 8aaa08e)

Co-authored-by: Ishan Loya <ishanloya@users.noreply.github.com>
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants