Skip to content

fix: batch errors are now rendered#2407

Merged
raizasafeel merged 1 commit into
frappe:developfrom
raizasafeel:fix/batch-creation
May 18, 2026
Merged

fix: batch errors are now rendered#2407
raizasafeel merged 1 commit into
frappe:developfrom
raizasafeel:fix/batch-creation

Conversation

@raizasafeel
Copy link
Copy Markdown
Contributor

@raizasafeel raizasafeel commented May 18, 2026

Summary

  • Creating a batch with missing required fields failed silently: frontend toast was blank, backend crashed before the mandatory check ran.

Changes

  • lms_batch.py: run _validate_mandatory() first
  • NewBatchModal.vue: fall back to a generic toast when err.messages is empty

@cypress
Copy link
Copy Markdown

cypress Bot commented May 18, 2026

lms    Run #3669

Run Properties:  status check passed Passed #3669  •  git commit 2d2b421784 ℹ️: Merge 9e4f1d831f62363c18e59df7626cf0e7493312f7 into 41fb007cc7d039190c6b141af896...
Project lms
Branch Review fix/batch-creation
Run status status check passed Passed #3669
Run duration 00m 26s
Commit git commit 2d2b421784 ℹ️: Merge 9e4f1d831f62363c18e59df7626cf0e7493312f7 into 41fb007cc7d039190c6b141af896...
Committer Raizaaa
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 1
View all changes introduced in this branch ↗︎

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.76%. Comparing base (41fb007) to head (9e4f1d8).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2407      +/-   ##
===========================================
+ Coverage    47.74%   47.76%   +0.02%     
===========================================
  Files          150      150              
  Lines         6658     6659       +1     
===========================================
+ Hits          3179     3181       +2     
+ Misses        3479     3478       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raizasafeel raizasafeel merged commit d23c98a into frappe:develop May 18, 2026
9 checks passed
@raizasafeel raizasafeel deleted the fix/batch-creation branch May 18, 2026 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants