Skip to content

fix: batch errors are now rendered #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raizasafeel merged 1 commit into from
May 18, 2026
+5 −3
Merged

fix: batch errors are now rendered #2407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions frontend/src/pages/Batches/components/NewBatchModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ import { Button, Dialog, FormControl, TextEditor, toast } from 'frappe-ui'
import { useOnboarding, useTelemetry } from 'frappe-ui/frappe'
import { computed, inject, onMounted, onBeforeUnmount, ref } from 'vue'
import { useRouter } from 'vue-router'
import { sanitizeHTML, createLMSCategory } from '@/utils'
import { sanitizeHTML, createLMSCategory, cleanError } from '@/utils'
import MultiSelect from '@/components/Controls/MultiSelect.vue'
import Link from '@/components/Controls/Link.vue'
import NewMemberModal from '@/components/Modals/NewMemberModal.vue'
Expand Down Expand Up @@ -214,7 +214,8 @@ const saveBatch = (close: () => void = () => {}) => {
}
},
onError(err: any) {
toast.error(cleanError(err.messages?.[0]))
const message = err?.messages?.[0]
toast.error(message ? cleanError(message) : __('Error creating batch'))
console.error(err)
},
}
Expand Down
3 changes: 2 additions & 1 deletion lms/lms/doctype/lms_batch/lms_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

class LMSBatch(Document):
def validate(self):
self._validate_mandatory()
self.validate_seats_left()
self.validate_batch_end_date()
self.validate_batch_time()
Expand All @@ -43,7 +44,7 @@ def on_update(self):
frappe.enqueue(send_notification_for_published_batch, batch=self)

def autoname(self):
if not self.name:
if not self.name and self.title:
self.name = generate_slug(self.title, "LMS Batch")

def validate_batch_end_date(self):
Expand Down
Loading