Open
Conversation
Member
Author
|
Note, due to the similarity in files, the GitHub change viewer is displaying this PR a little weirdly |
Member
Author
|
Also, I have taken the time to build and test this on my end already. It is ready for testing on real hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometime over the past few years, people have started copy-pasting parts of lib5k directly into the robot projects. We never designed Lib5K to survive without the whole library along for the ride since it makes such heavy use of telemetry and custom logging infrastructure.
The module that is named
com.team5024.lib.statemachinesin this repository is actually a library calledLibKontrolthat a few of us built back in 2019/2020.Since it is such a key part of the robot code, I've decided to take some time to properly package up the code for the team. I've also bundled in the original documentation that explains how to use the library.
Also, some of the logging logic in your copy didn't quite match the field-tested version we used to use, so I've fixed that up too (conveniently dropping the dependency on
RobotLogger)