Skip to content

Use the correct LibKontrol library#7

Open
ewpratten wants to merge 3 commits intoMasterfrom
ewpratten/libkontrol
Open

Use the correct LibKontrol library#7
ewpratten wants to merge 3 commits intoMasterfrom
ewpratten/libkontrol

Conversation

@ewpratten
Copy link
Copy Markdown
Member

Sometime over the past few years, people have started copy-pasting parts of lib5k directly into the robot projects. We never designed Lib5K to survive without the whole library along for the ride since it makes such heavy use of telemetry and custom logging infrastructure.

The module that is named com.team5024.lib.statemachines in this repository is actually a library called LibKontrol that a few of us built back in 2019/2020.

Since it is such a key part of the robot code, I've decided to take some time to properly package up the code for the team. I've also bundled in the original documentation that explains how to use the library.

Also, some of the logging logic in your copy didn't quite match the field-tested version we used to use, so I've fixed that up too (conveniently dropping the dependency on RobotLogger)

@ewpratten ewpratten added the enhancement New feature or request label Feb 17, 2024
@ewpratten ewpratten requested a review from awpratten February 17, 2024 18:15
@ewpratten
Copy link
Copy Markdown
Member Author

Note, due to the similarity in files, the GitHub change viewer is displaying this PR a little weirdly

@ewpratten
Copy link
Copy Markdown
Member Author

Also, I have taken the time to build and test this on my end already. It is ready for testing on real hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant