Skip to content

Conversation

@rocodes
Copy link
Contributor

@rocodes rocodes commented Aug 12, 2025

Update protocol specification to 0.3, to match what is currently being drafted:

  • Updated keys list
  • Updated message encryption
  • Algorithms
  • Protocol overview

@rocodes rocodes force-pushed the message-enc-flow-doc branch 2 times, most recently from 6dda11a to a0252a8 Compare August 27, 2025 18:55
@cfm cfm self-requested a review August 27, 2025 19:02
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great for the purposes of #85! I've left comments inline as they came to me, but take 'em or leave 'em as you see fit between here and updating protocol.md.

@cfm cfm added this to SecureDrop Aug 28, 2025
@cfm cfm moved this to Under Review in SecureDrop Aug 28, 2025
@rocodes rocodes mentioned this pull request Sep 4, 2025
9 tasks
@cfm cfm self-assigned this Sep 8, 2025
@cfm cfm moved this from Under Review to In Progress in SecureDrop Sep 8, 2025
@cfm cfm moved this from In Progress to Blocked or Waiting in SecureDrop Sep 11, 2025
@cfm cfm force-pushed the message-enc-flow-doc branch from 411514b to f97145b Compare September 12, 2025 00:41
@cfm cfm moved this from Blocked or Waiting to Ready For Review in SecureDrop Sep 12, 2025
@cfm cfm marked this pull request as ready for review September 12, 2025 01:50
@cfm
Copy link
Member

cfm commented Sep 12, 2025

I did a pass on the "Keys" section today per #101. I'm marking this as ready for review mostly to discuss with @rocodes next week whether to tackle the rest of #101 here or split it up for incremental review.

@cfm cfm changed the title WIP: Updated keys and protcol message desc revise key schedule; notes on revised protocol flows Sep 12, 2025
@cfm cfm added this to the v0.3 milestone Sep 12, 2025
@cfm cfm moved this from Ready For Review to In Progress in SecureDrop Sep 24, 2025
@cfm
Copy link
Member

cfm commented Sep 24, 2025

Moving this back to "in progress" because I suspect this is going to become the catchment pull request in which we accumulate the v0.3 specification for merge into main. :-)

@rocodes rocodes changed the title revise key schedule; notes on revised protocol flows [WIP] Updated 0.3 specification Sep 24, 2025
@rocodes rocodes force-pushed the message-enc-flow-doc branch from 8f6b354 to 99f0e99 Compare September 25, 2025 02:16
@cfm
Copy link
Member

cfm commented Oct 17, 2025

Thanks, @rocodes! Based on our conversation today, here's a possible path to merging this into main as v0.3:

  1. docs: reconcile key setup (including signatures) with schedule #110 is ready for review (now neutral documentation)
  2. docs: reduce pseudocode to HPKE single-shot APIs #111 I'll finish tomorrow
  3. Maybe we remove the overview sequence diagram for now?
  4. The remaining tasks in update protocol specification from manuscript in progress #101 can be follow-up work...
  5. ...along with incremental revisions as we consider them?

What do you think? I think (5) really captures my goal at this point: to be able to consider incremental revisions on this foundation.

@cfm
Copy link
Member

cfm commented Oct 18, 2025

As of today:

  1. docs: reconcile key setup (including signatures) with schedule #110 is ready for review (now neutral documentation)
  2. docs: reduce pseudocode to HPKE single-shot APIs #111 I'll finish tomorrow
  3. Maybe we remove the overview sequence diagram for now?

@rocodes, feel free to tag me next week on anything we need to get this into main!

@cfm cfm moved this from In Progress to Ready For Review in SecureDrop Oct 20, 2025
docs: reduce pseudocode to HPKE single-shot APIs
@rocodes rocodes changed the title [WIP] Updated 0.3 specification Updated 0.3 specification Oct 20, 2025
@rocodes rocodes force-pushed the message-enc-flow-doc branch from 6e362d7 to 13af4dd Compare October 21, 2025 14:42
@rocodes
Copy link
Contributor Author

rocodes commented Oct 21, 2025

I've added a couple of notes from the WIP 0.3 md doc to the protocol readme.md about future discussion areas, and I think everything else is captured in protocol.md, so I have deleted the 0.3-wip doc. I think this is ready for main, pending CI.

@cfm cfm self-requested a review October 21, 2025 15:36
@cfm cfm unassigned rocodes Oct 21, 2025
@rocodes
Copy link
Contributor Author

rocodes commented Oct 21, 2025

(cherry-picked last commit from #112)

@cfm cfm moved this from Ready For Review to Under Review in SecureDrop Oct 22, 2025
Copy link
Member

@cfm cfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huzzah. Thanks for tag-teaming on this, @rocodes!

@cfm cfm added this pull request to the merge queue Oct 22, 2025
Merged via the queue into main with commit 747d630 Oct 22, 2025
2 checks passed
@github-project-automation github-project-automation bot moved this from Under Review to Done in SecureDrop Oct 22, 2025
@nathandyer nathandyer removed this from SecureDrop Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants