フッターに関連サイトへのリンクを追加した #382
フッターに関連サイトへのリンクを追加した #382
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds related site links to the footer of the freee accessibility guidelines website. The changes include links to freee's accessibility initiatives and customer case studies with multilingual support.
- Added two related site links in the footer with conditional Japanese/English text
- Implemented CSS styling for the new footer links with flexbox layout
- Added language-aware link text using Jinja2 templating
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ja/source/_templates/footer.html | Added related sites links with multilingual support using conditional templating |
| ja/source/_static/a11y-gl.css | Added CSS styling for the related sites list with flexbox layout |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ja/source/_templates/footer.html
Outdated
| @@ -1,5 +1,6 @@ | |||
| {% extends "!footer.html" %} | |||
| {% block extrafooter %} | |||
| <ul class="related-sites"><li><a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja">{% if language == 'ja' -%}freeeのアクセシビリティーの取り組み{%- else -%}Accessibility at freee (Japanese){%- endif %}</a></li><li><a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja">{% if language == 'ja' -%}freee製品の導入事例{%- else -%}Customer Stories (Japanese){%- endif %}</a></li></ul> | |||
There was a problem hiding this comment.
This entire HTML structure is on a single line, making it difficult to read and maintain. Consider breaking it into multiple lines with proper indentation for better readability.
| <ul class="related-sites"><li><a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja">{% if language == 'ja' -%}freeeのアクセシビリティーの取り組み{%- else -%}Accessibility at freee (Japanese){%- endif %}</a></li><li><a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja">{% if language == 'ja' -%}freee製品の導入事例{%- else -%}Customer Stories (Japanese){%- endif %}</a></li></ul> | |
| <ul class="related-sites"> | |
| <li> | |
| <a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja"> | |
| {% if language == 'ja' -%} | |
| freeeのアクセシビリティーの取り組み | |
| {%- else -%} | |
| Accessibility at freee (Japanese) | |
| {%- endif %} | |
| </a> | |
| </li> | |
| <li> | |
| <a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja"> | |
| {% if language == 'ja' -%} | |
| freee製品の導入事例 | |
| {%- else -%} | |
| Customer Stories (Japanese) | |
| {%- endif %} | |
| </a> | |
| </li> | |
| </ul> |
| .related-sites { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| gap: 0.5rem 1.5rem; |
There was a problem hiding this comment.
The CSS property margin-block may not be supported in older browsers. Consider using margin-top and margin-bottom for better browser compatibility, or provide a fallback.
| gap: 0.5rem 1.5rem; | |
| gap: 0.5rem 1.5rem; | |
| margin-top: 1rem; | |
| margin-bottom: 1rem; |
There was a problem hiding this comment.
表示上問題がなければ、内容的には問題なさそそうです。
ただ、可読性を考えて複数行で記述する方が良いと思います。
There was a problem hiding this comment.
僕もできれば改行したい気持ちなのですが、改行するとビルド後のHTMLに改行文字が として出力されてしまい、悩みどころでした 💭
There was a problem hiding this comment.
…が、もういちどローカル環境でビルドを試したところ、まったくそんな挙動はありませんでした…！！
謎の勘違いだったようで、 80ba570 で取り込ませていただきました。失礼しました！
2 participants
フッターに、以下の関連サイトへのリンクを追加しました。