Skip to content

フッターに関連サイトへのリンクを追加した #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shikakun merged 2 commits into from
Aug 26, 2025
Merged

フッターに関連サイトへのリンクを追加した #382

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0518ea2
フッターに関連サイトへのリンクを追加した
shikakun Aug 25, 2025
80ba570
改行して可読性を向上した
shikakun Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ja/source/_static/a11y-gl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,3 +87,11 @@ body {
outline: 2px dashed #5b9dd9;
outline-offset: 2px;
}

/* フッターの関連サイトへのリンク */
.related-sites {
display: flex;
flex-wrap: wrap;
gap: 0.5rem 1.5rem;
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CSS property margin-block may not be supported in older browsers. Consider using margin-top and margin-bottom for better browser compatibility, or provide a fallback.

Suggested change
gap: 0.5rem 1.5rem;
gap: 0.5rem 1.5rem;
margin-top: 1rem;
margin-bottom: 1rem;

Copilot uses AI. Check for mistakes.
margin-block: 1rem;
}
1 change: 1 addition & 0 deletions ja/source/_templates/footer.html
View file
Open in desktop
Copy link
Member

@ma10 ma10 Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表示上問題がなければ、内容的には問題なさそそうです。
ただ、可読性を考えて複数行で記述する方が良いと思います。

Copy link
Contributor Author

@shikakun shikakun Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

僕もできれば改行したい気持ちなのですが、改行するとビルド後のHTMLに改行文字が   として出力されてしまい、悩みどころでした 💭

Copy link
Contributor Author

@shikakun shikakun Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

…が、もういちどローカル環境でビルドを試したところ、まったくそんな挙動はありませんでした…！！
謎の勘違いだったようで、 80ba570 で取り込ませていただきました。失礼しました！

Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{% extends "!footer.html" %}
{% block extrafooter %}
<ul class="related-sites"><li><a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja">{% if language == 'ja' -%}freeeのアクセシビリティーの取り組み{%- else -%}Accessibility at freee (Japanese){%- endif %}</a></li><li><a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja">{% if language == 'ja' -%}freee製品の導入事例{%- else -%}Customer Stories (Japanese){%- endif %}</a></li></ul>
Copy link

Copilot AI Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This entire HTML structure is on a single line, making it difficult to read and maintain. Consider breaking it into multiple lines with proper indentation for better readability.

Suggested change
<ul class="related-sites"><li><a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja">{% if language == 'ja' -%}freeeのアクセシビリティーの取り組み{%- else -%}Accessibility at freee (Japanese){%- endif %}</a></li><li><a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja">{% if language == 'ja' -%}freee製品の導入事例{%- else -%}Customer Stories (Japanese){%- endif %}</a></li></ul>
<ul class="related-sites">
<li>
<a href="https://www.freee.co.jp/accessibility" target="_blank" hreflang="ja">
{% if language == 'ja' -%}
freeeのアクセシビリティーの取り組み
{%- else -%}
Accessibility at freee (Japanese)
{%- endif %}
</a>
</li>
<li>
<a href="https://www.freee.co.jp/cases/?cond=issue~issue-28" target="_blank" hreflang="ja">
{% if language == 'ja' -%}
freee製品の導入事例
{%- else -%}
Customer Stories (Japanese)
{%- endif %}
</a>
</li>
</ul>

Copilot uses AI. Check for mistakes.
<p>
{% if language == 'ja' -%}
<a rel="license" href="http://creativecommons.org/licenses/by/4.0/"><img alt="クリエイティブ・コモンズ・ライセンス" style="border-width:0" src="https://i.creativecommons.org/l/by/4.0/88x31.png" /></a><br /> <a xmlns:cc="http://creativecommons.org/ns#" href="https://www.freee.co.jp/" property="cc:attributionName" rel="cc:attributionURL">フリー株式会社</a> 作『<span xmlns:dct="http://purl.org/dc/terms/" property="dct:title">freeeアクセシビリティー・ガイドライン</span>』は<a rel="license" href="http://creativecommons.org/licenses/by/4.0/">クリエイティブ・コモンズ 表示 4.0 国際 ライセンス</a>で提供されています。
Expand Down