Skip to content

Commit 05e573a

Browse files
authored
Apply suggestions from code review
1 parent a316211 commit 05e573a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/main/scala/com/fulcrumgenomics/fastq/FastqToBam.scala

+1-1
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ class FastqToBam
123123
validate(input.length == actualReadStructures.length, "input and read-structure must be supplied the same number of times.")
124124
validate(1 to 2 contains actualReadStructures.flatMap(_.templateSegments).size, "read structures must contain 1-2 template reads total.")
125125
validate(!extractUmisFromReadNames || umiQualTag.isEmpty, "Cannot extract UMI qualities when also extracting UMI from read names.")
126-
validate(!extractUmisFromReadComment || umiQualTag.isEmpty, "Cannot extract UMI qualities when also extracting UMI from read description.")
126+
validate(!extractUmisFromReadComment || umiQualTag.isEmpty, "Cannot extract UMI qualities when also extracting UMI from the comment in the read name.")
127127

128128
override def execute(): Unit = {
129129
val encoding = qualityEncoding

src/test/scala/com/fulcrumgenomics/umi/UmisTest.scala

+3-3
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class UmisTest extends UnitSpec with OptionValues {
4343
Umis.extractUmisFromReadName("1:2:3:4:5:6:7:ACGTACGT", strict=true).value shouldBe "ACGTACGT"
4444
}
4545

46-
it should "return None if the read has only 7 parts in strict mode" in {
46+
it should "return None if the read name has only 7 parts in strict mode" in {
4747
Umis.extractUmisFromReadName("1:2:3:4:5:6:7", strict=true) shouldBe None
4848
}
4949

@@ -126,7 +126,7 @@ class UmisTest extends UnitSpec with OptionValues {
126126
copyUmiFromReadName(rec=rec("UMI:C:ACC+GGT"), removeUmi=true).nameAndUmi shouldBe ("UMI:C", "ACC-GGT")
127127
}
128128

129-
it should "split on a different delimiter if specified" in {
129+
it should "split on a different delimiter name if specified" in {
130130
copyUmiFromReadName(rec=rec("UMI-A"), delimiter='-').nameAndUmi shouldBe ("UMI-A", "A")
131131
copyUmiFromReadName(rec=rec("UMI-C-A"), delimiter='-').nameAndUmi shouldBe ("UMI-C-A", "A")
132132
copyUmiFromReadName(rec=rec("UMI-C-ACC+GGT"), delimiter='-').nameAndUmi shouldBe ("UMI-C-ACC+GGT", "ACC-GGT")
@@ -136,7 +136,7 @@ class UmisTest extends UnitSpec with OptionValues {
136136
copyUmiFromReadName(rec=rec("UMI:C:ACC+GGT")).nameAndUmi shouldBe ("UMI:C:ACC+GGT", "ACC-GGT")
137137
}
138138

139-
it should "fail if the read has only one field" in {
139+
it should "fail if the read name has only one field" in {
140140
an[Exception] should be thrownBy copyUmiFromReadName(rec=rec("NAME"))
141141
an[Exception] should be thrownBy copyUmiFromReadName(rec=rec("1-2"))
142142
}

0 commit comments

Comments
 (0)