Skip to content

Commit d85efb9

Browse files
authored
fix: ensure that the GroupReadsByUmiTests for marking duplicates are (#962)
actually run The tests did not check for non-empty output, so would pass even if the tool was not being executed
1 parent afa634e commit d85efb9

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/test/scala/com/fulcrumgenomics/umi/GroupReadsByUmiTest.scala

+4
Original file line numberDiff line numberDiff line change
@@ -287,8 +287,10 @@ class GroupReadsByUmiTest extends UnitSpec with OptionValues with PrivateMethodT
287287
val gr = new GroupReadsByUmi(input=in, output=out, familySizeHistogram=Some(hist), strategy=Strategy.Paired, edits=1, markDuplicates=true)
288288

289289
gr.markDuplicates shouldBe true
290+
gr.execute()
290291

291292
val recs = readBamRecs(out)
293+
recs.length shouldBe 8
292294
recs.filter(_.name.equals("a01")).forall(_.duplicate == true) shouldBe true
293295
recs.filter(_.name.equals("a02")).forall(_.duplicate == true) shouldBe true
294296
recs.filter(_.name.equals("a03")).forall(_.duplicate == false) shouldBe true
@@ -309,6 +311,7 @@ class GroupReadsByUmiTest extends UnitSpec with OptionValues with PrivateMethodT
309311
new GroupReadsByUmi(input=in, output=out, familySizeHistogram=Some(hist), strategy=Strategy.Paired, edits=1).execute()
310312

311313
val recs = readBamRecs(out)
314+
recs.length shouldBe 6
312315
recs.filter(_.name.equals("a01")).forall(_.duplicate == false) shouldBe true
313316
recs.filter(_.name.equals("a02")).forall(_.duplicate == false) shouldBe true
314317
recs.filter(_.name.equals("a03")).forall(_.duplicate == false) shouldBe true
@@ -328,6 +331,7 @@ class GroupReadsByUmiTest extends UnitSpec with OptionValues with PrivateMethodT
328331
new GroupReadsByUmi(input = in, output = out, familySizeHistogram = Some(hist), rawTag = "RX", assignTag = "MI", strategy = Strategy.Edit, edits = 1, markDuplicates = true).execute()
329332

330333
val recs = readBamRecs(out)
334+
recs.length shouldBe 4
331335
recs.filter(_.name.equals("a01")).forall(_.duplicate == false) shouldBe true
332336
recs.filter(_.name.equals("a02")).forall(_.duplicate == true) shouldBe true
333337
recs.filter(_.name.equals("a03")).forall(_.duplicate == false) shouldBe true

0 commit comments

Comments
 (0)