-
Notifications
You must be signed in to change notification settings - Fork 1
Clipping plane slider layer controls #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…easier reuse in other layers
…s layers can share their clipping plane settings
…that it can be synced with image/labels layers
…hat it can be synced with image/labels layers
…osition to make the tests work (should be fine?)
…bobox is properly updated
…depending on the depiction
…tLayerDepiction, and prevent duplicate connections
…d of unnecessary if statement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 89.37% 89.48% +0.10%
==========================================
Files 651 650 -1
Lines 59932 60162 +230
==========================================
+ Hits 53565 53835 +270
+ Misses 6367 6327 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…center of the clipping planes
…nd width_slider assuming not taking the absolute range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay - I finally went through and read all the code changes. Left some comments that are mostly for my understanding or about renaming stuff. Overall I love it!! The test of the linking that you added made me very happy 😄. Once the renaming questions are decided we can merge!
Thanks for your review and comments! I tried to address them as much as possible. I just could not find a better way to add the widget while maintaining a consistent layout, and I am not sure about the action manager, what do you think we should do here? |
All good about the per-row addition - I just was wondering if there was a better way, but I believe you that there is not! |
Proposed Change
Implementation of UI controls for the 'experimental clipping planes' feature. Both image and labels layer controls show tools to set the plane and clipping plane values (only when a layer is displayed in 3D and has >=3 dimensions). By clicking the 'clipping plane' checkbox, users can (de)activate the clipping planes. The planeNormalButtons are used for setting both the plane and the clipping plane normals simultaneously. I added the 'experimental_clipping_planes' event to the Points and Tracks layers as well. They do not have UI tools, but this allows the clipping plane settings to be synced across image/labels/points/tracks layers with the 'link_layers' function (or in the UI by selecting layers and right-click > link layers). The clipping plane event is linked for all layers from the TracksLayerGroup by default, but this can be deactivated with TracksLayerGroup.unlink_clipping_planes() function.
Checklist
Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.
Further Comments