Skip to content

Orthogonal views #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Orthogonal views #42

wants to merge 12 commits into from

Conversation

AnniekStok
Copy link
Collaborator

Proposed Change

Add additional viewer models to view the orthogonal views (xz, yz) of the same data.
All interactive functionality (painting, selecting nodes, changing tool modes, undo/redo) should sync between the different viewers.

image

Checklist

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.

Further Comments

  • How to best extend/change this in order to also allow viewing different data (e.g. reference data) or the same data but at t+1? How can we best give the user more freedom about what to display in the different viewer models?
  • If the content of the different viewer models diverges from the main viewer, we will need separate Qt layer controls per layer per viewing model. Right now we only have the Qt layer controls of the layer on the main viewer, and sync the properties such as 'mode' and 'n_edit_dimensions'.
  • Currently the different viewer models are not dockable (though the window can optionally be hidden/resized). Trying to undock the entire widget kills the application for unclear reasons if it contains any viewer models :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant