Fix LSD computation and add tests for empty labels #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a segmentation contains only background (label 0), get_lsds crashes because the label_descriptors list is empty. With empty label_descriptors:
np.sum(np.array([])) returns a scalar 0.0
np.clip(descriptors, 0.0, 1.0, out=descriptors) then fails with
TypeError: return arrays must be of ArrayType.This PR adds a check for empty label_descriptors and returns zeros with the correct shape (channels, *segmentation.shape) instead.
Changes:
src/lsd_lite/lsds.py: Handle empty label case before np.sum/np.clip
tests/conftest.py: Add empty_labels fixture
tests/test_lsds.py: Add test_empty_labels
tests/test_affs.py: Add test_empty_labels for both distance functions