Ports the service job board - #287
Merged
Merged
Conversation
* init * progress * entities & job randomization * the linterrrrrrrrr * you can now claim shit * everything except the actual events * OOPS! OOPS! OOPS! * its done until someone (NOT ME!) decides to add more jobs * oopsy * req changes # Conflicts: # Resources/Prototypes/_Impstation/Catalog/Fills/Lockers/heads.yml # Resources/Prototypes/_Impstation/Entities/Objects/Devices/flatpack.yml # Resources/Textures/_Impstation/Structures/Machines/computers.rsi/meta.json
ReconPangolin
marked this pull request as ready for review
August 8, 2026 11:54
Collaborator
|
Test fails related, please fix before we can merge. |
Contributor
Author
|
It should be fixed now, I failed a test relating to organs and landmines locally but I can't see how this would affect that. |
pirakaplant
approved these changes
Aug 12, 2026
pirakaplant
left a comment
Contributor
There was a problem hiding this comment.
The Minute of Silence entry is misaligned because it's the only one not long enough to fill out at least a full line of text but I'm probably going to remove it anyway when I curate the events myself a bit later and add some more.
Everything else works. Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the PR
Ports impstation/imp-station-14#3377
Adds a new computer where service jobs can be accepted that correspond to events such as a tournament, a race, a party or a scavenger hunt.
Why / Balance
The service board incentives the service department to run fun roleplaying events, see funky-station/docs#96.
Technical details
Uses ServiceJobBoardSystem, ServiceJobsDataComponent and ServiceJobBoardConsoleComponent to run service events. These events are ServiceJobPrototypes which are defined in Resources/Prototypes/_Impstation/Service/servicejobs.yml.
Test plan
Media
Requirements
License
MIT
Breaking changes
No breaking changes, comment out the two entities in Resources/Prototypes/_Impstation/Entities/Structures/Machines/Computers/service_job_console.yml and Resources/Prototypes/_Impstation/Entities/Objects/Devices/flatpack.yml to disable.
Changelog
🆑 ReconPangolin, mqole