Add support for API auth with access token #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
force-pushed
the
add_support_for_access_tokens
branch
from
4ae8b13 to
e227bdf
Compare
nsoranzo
reviewed
Nov 11, 2023
nuwang
force-pushed
the
add_support_for_access_tokens
branch
2 times, most recently
from
516eceb to
3721c55
Compare
nsoranzo
reviewed
Nov 12, 2023
nuwang
force-pushed
the
add_support_for_access_tokens
branch
2 times, most recently
from
7b1f50d to
09b340f
Compare
nsoranzo
reviewed
Nov 12, 2023
There was a problem hiding this comment.
I guess something will need to be done also for the tus upload https://github.com/galaxyproject/bioblend/blob/main/bioblend/galaxyclient.py#L330 ?
Ping @natefoo
|
@nuwang Do you want to rebase this now that the Galaxy PR has been merged? |
nsoranzo
reviewed
Jul 9, 2024
Comment on lines
+77
to
+81
| elif token: | ||
| self.token: Optional[str] = token |
There was a problem hiding this comment.
Suggested change
| elif token: | |
| self.token: Optional[str] = token |
There was a problem hiding this comment.
@nsoranzo Do you recall why you suggested removing these two lines?
There was a problem hiding this comment.
Probably because self.token is not (currently) used anywhere.
nuwang
force-pushed
the
add_support_for_access_tokens
branch
from
09b340f to
321cbc6
Compare
Co-authored-by: Nicola Soranzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: galaxyproject/galaxy#16977
This is the line where the tus client seems to rely on
x-api-keythat I mentioned @mvdbeek:bioblend/bioblend/galaxyclient.py
Line 329 in 933b910