Fix loading spinner positioning in admin grid #21564
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace BOverlay with custom loading overlay that properly centers the spinner within the grid viewport. Uses GalaxyLoader for both initial load and search/filter states for consistent branding. The BOverlay component's spinner was appearing off-screen for long scrollable tables because it centered within the full table height rather than the visible viewport. Fixes galaxyproject#21438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace BOverlay with custom loading overlay that properly centers the spinner within the grid viewport. Uses GalaxyLoader for both initial load and search/filter states for consistent branding.
The BOverlay component's spinner was appearing off-screen for long scrollable tables because it centered within the full table height rather than the visible viewport.
Fixes #21438
How to test the changes?
(Select all options that apply)
License