Add tests for oidc usernames #21655
Merged
Add tests for oidc usernames #21655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
force-pushed
the
improve_oidc_username_tests
branch
from
292b0e0 to
30b0f00
Compare
jmchilton
approved these changes
Jan 28, 2026
jmchilton
reviewed
Jan 28, 2026
| self._assert_status_code_is(response, 200) | ||
| assert response.json()["email"] == "[email protected]" | ||
|
|
||
| def test_oidc_login_username_sanitization(self): |
Member
There was a problem hiding this comment.
This is a really beautiful test setup - what a cool way to bootstrap auth-based testing! Not added here per se but I wanted to compliment it. These particular tests are also really clear and useful.
Member
Author
There was a problem hiding this comment.
Thank you. Claude helped with all the boilerplate.
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more tests to ensure that oidc usernames conform to galaxy requirements.
Fixed in: #21234
closes: #20767
How to test the changes?
(Select all options that apply)
License