Skip to content

[25.1] Fix database migration error from 25.0 > 25.1 #21737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jdavcs wants to merge 1 commit into
base: release_25.1
Choose a base branch
from
Open

[25.1] Fix database migration error from 25.0 > 25.1 #21737

jdavcs wants to merge 1 commit into from
+5 −2

Conversation

@jdavcs
Copy link
Member

@jdavcs jdavcs commented Feb 3, 2026 •
edited
Loading

Fix #21699.

This is needed because the migration adding these fields was added to 25.1, fixing a bug in 24.2. So if a new galaxy db was created under versions 24.2 or 25.0, these fields were added from the model during startup. Thus, in that case, there was no path to safely migrate to 25.1, as the fields that were being added in the migration were already in the database - hense, the migration error.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs
Check if fields exist
2e91226 
This is needed because the migration adding these fields was added to
25.1, fixing a bug in 24.2. So if a new galaxy db was created at or
after 24.2, these fields were added from the model, so there was no path
to migrate to 25.1, as the fields that were added in the migration would
have already been added by galaxy on initial startup.
@jdavcs jdavcs added kind/bug area/database Galaxy's database or data access layer labels Feb 3, 2026
@github-actions github-actions bot added this to the 26.1 milestone Feb 3, 2026
@jdavcs jdavcs changed the title [25.1] Check if fields exist [25.1] Fix database migration error from 25.0 > 25.1 Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees

No one assigned

Labels

area/database Galaxy's database or data access layer kind/bug

Projects

None yet

Milestone

26.1

Development

Successfully merging this pull request may close these issues.

2 participants

@jdavcs @nsoranzo