-
Notifications
You must be signed in to change notification settings - Fork 454
Add fastplong to tools #6940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add fastplong to tools #6940
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please feel free to add yourself as creator
to the tool and consider using a section for more advanced parameters.
Thanks for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if there is a significant overlap of parameters with fastp that we should use
Co-authored-by: Saim Momin <[email protected]> Co-authored-by: Björn Grüning <[email protected]>
Co-authored-by: Saim Momin <[email protected]>
this is what galaxy manages on their behalf
@@ -0,0 +1,3 @@ | |||
<macros> | |||
<token name="@TOOL_VERSION@">0.2.2</token> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this macro can be moved into the main file. A separate Macro file only makes sense imho if you have a lot of macros that are shared between multiple tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if you can also add min/max values to integer/float parameters where it makes sense. min="1" for example.
removed the option to set json and html filename
FOR CONTRIBUTOR: