Skip to content

add wrapper for telogator2#7481

Merged
bernt-matthias merged 10 commits intogalaxyproject:mainfrom
Smeds:add-telogator2
Dec 4, 2025
Merged

add wrapper for telogator2#7481
bernt-matthias merged 10 commits intogalaxyproject:mainfrom
Smeds:add-telogator2

Conversation

@Smeds
Copy link
Contributor

@Smeds Smeds commented Nov 21, 2025

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

@Smeds Smeds marked this pull request as draft November 21, 2025 19:35
@Smeds
Copy link
Contributor Author

Smeds commented Nov 21, 2025

will stay in draft mode until I can add the tool for building reference files

@Smeds Smeds closed this Nov 21, 2025
@Smeds Smeds reopened this Nov 21, 2025

<section name="reference_opts" title="Reference Options" expanded="false">
<param name="custom_reference" argument="-t" type="data" format="fasta" optional="true" label="Custom reference FASTA" help="Optional custom telogator reference FASTA file. If not provided, built-in human T2T reference will be used."/>
<param name="kmer_file" argument="-k" type="data" format="txt" optional="true" label="Telomere kmers file" help="Optional telomere kmers file (required for non-human organisms like mouse or maize)"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any more info in this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Information about the kmer file is currently very sparse on in the repo. I have asked them to add more information about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernt-matthias I'm in the process of adding information to there git-repo about the format of the file. Should it also be included in the wrapper or would it be enough to reference the git-repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both fine.

@Smeds Smeds marked this pull request as ready for review December 3, 2025 20:50
@Smeds Smeds requested a review from bernt-matthias December 3, 2025 21:29
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do these 2-4 changes and then its good to go.

Co-authored-by: M Bernt <m.bernt@ufz.de>
@Smeds
Copy link
Contributor Author

Smeds commented Dec 4, 2025

Lets do these 2-4 changes and then its good to go.

@bernt-matthias done!

Copy link
Contributor

@SaimMomin12 SaimMomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestions :)

bernt-matthias and others added 2 commits December 4, 2025 17:35
Co-authored-by: Saim Momin <64724322+SaimMomin12@users.noreply.github.com>
Co-authored-by: Saim Momin <64724322+SaimMomin12@users.noreply.github.com>
@bernt-matthias bernt-matthias enabled auto-merge (squash) December 4, 2025 16:36
@bernt-matthias bernt-matthias merged commit ff18f7a into galaxyproject:main Dec 4, 2025
8 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Dec 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants