Skip to content

[WIP] Remove .lint_skip files (1)#7892

Closed
SaimMomin12 wants to merge 3 commits intogalaxyproject:mainfrom
SaimMomin12:lint_skip_1
Closed

[WIP] Remove .lint_skip files (1)#7892
SaimMomin12 wants to merge 3 commits intogalaxyproject:mainfrom
SaimMomin12:lint_skip_1

Conversation

@SaimMomin12
Copy link
Copy Markdown
Contributor

#7890

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

There are two labels that allow to ignore specific (false positive) tool linter errors:

  • skip-version-check: Use it if only a subset of the tools has been updated in a suite.
  • skip-url-check: Use it if github CI sees 403 errors, but the URLs work.

@bernt-matthias
Copy link
Copy Markdown
Contributor

I would suggest to open different PRs for each tool.

@SaimMomin12
Copy link
Copy Markdown
Contributor Author

I would suggest to open different PRs for each tool.

Sure, would do that. Another question I have is, do we bump the tool versions after fixing the linting issues? Initially, I assumed no but open for suggestions.

@SaimMomin12
Copy link
Copy Markdown
Contributor Author

Continued in #7898 #7899 #7900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants