Make testinstall work with gap --bare - #6354
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6354 +/- ##
==========================================
+ Coverage 78.83% 78.86% +0.02%
==========================================
Files 685 685
Lines 293554 293553 -1
Branches 8648 8648
==========================================
+ Hits 231432 231519 +87
+ Misses 60314 60226 -88
Partials 1808 1808 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a3ea9e6 to
2a6237a
Compare
35260cd to
1dc65c5
Compare
|
The failure is due to the fact that As far as I see, this is just about a few text constants. We could set them as in the current GAPDoc's |
|
I've added a commit to deal with the |
|
Only failure now is in I won't get that done for GAP 4.16.0. But I've restricted the other remaining changes from this PR into PR #6406 |
ThomasBreuer
left a comment
There was a problem hiding this comment.
Only failure now is in
tst/testinstall/package.tstwhich loadsmockpkgwhich in turn "needs"GAPDoc, which then gets loaded and prints a banner.
I see: Some tests of package extensions are based on the assumption that some GAPDoc version is already loaded. Simply removing GAPDoc from the list of needed packages of mockpkg is not a solution.
Besides this problem, everything looks well. Thanks for this work.
5ca1bd4 to
96218d0
Compare
6c18012 to
61cdcac
Compare
Resolves #6346