Skip to content

Make testinstall work with gap --bare #6354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fingolfin merged 1 commit into from
May 27, 2026
Merged

Make testinstall work with gap --bare #6354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
test-suites:
[
# base test: fast first test
"testinstall",
"testinstall-bare",

"teststandard",

Expand Down
4 changes: 4 additions & 0 deletions dev/ci.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,10 @@ GAPInput

;;

testinstall-bare)
$GAP $(gap_cover_arg) --bare $SRCDIR/tst/testinstall.g
;;

*)
if [[ ! -f $SRCDIR/tst/${TEST_SUITE}.g ]]
then
Expand Down
4 changes: 4 additions & 0 deletions tst/testinstall/maxsub.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,14 @@ gap> SortedList(List(msc, IndexInParent));
[ 2, 3, 4 ]

#
#@if IsPackageMarkedForLoading( "primgrp", "" )
gap> G := GL(2,4);;
gap> msc:=MaximalSubgroupClassReps(G);;
gap> ForAll(msc, H -> Parent(H) = G);
true
gap> SortedList(List(msc, IndexInParent));
[ 3, 5, 6, 10 ]
#@fi

#
gap> G := GL(2,5);;
Expand All @@ -25,10 +27,12 @@ gap> SortedList(List(msc, IndexInParent));
[ 2, 5, 6, 10 ]

#
#@if IsPackageMarkedForLoading( "primgrp", "" )
gap> G := AlternatingGroup(5);;
gap> msc := MaximalSubgroupClassReps(G);;
gap> SortedList(List(msc, H -> Index(G, H)));
[ 5, 6, 10 ]
#@fi

#
gap> STOP_TEST("maxsub.tst");
11 changes: 9 additions & 2 deletions tst/testinstall/package.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,9 +435,11 @@ false
gap> IsPackageLoaded("mockpkg", ">=2.0");
false

#
# instruct GAP to load the package, and record all its declarations
# the help book of mockpkg might already have been loaded in other tests
# -> we suppress a warning about this
#@if IsPackageMarkedForLoading( "gapdoc", "" )
gap> old_warning_level := InfoLevel( InfoWarning );;
gap> SetInfoLevel( InfoWarning, 0 );
gap> PackageVariablesInfo("mockpkg", "0.1");;
Expand Down Expand Up @@ -481,9 +483,14 @@ gap> IsDateFormatValid := function( datestring )
> end;;
gap> IsDateFormatValid( GAPInfo.Date );
true
#@else
gap> LoadPackage("mockpkg", false);
oops, should not print here
true
#@fi

# Test the Cite() command (output changed with GAPDoc 1.6.6 and again with 1.6.7)
#@if CompareVersionNumbers(InstalledPackageVersion("gapdoc"), "1.6.7")
#@if IsPackageMarkedForLoading( "gapdoc", "1.6.7" )
gap> Cite("mockpkg");
Please use one of the following samples
to cite mockpkg version from this installation
Expand Down Expand Up @@ -538,7 +545,7 @@ rg/}}},
}


#@else
#@elif IsPackageMarkedForLoading( "gapdoc", "" )
gap> Cite("mockpkg");
Please use one of the following samples
to cite mockpkg version from this installation
Expand Down
Loading