Skip to content

fix(lint): handle resp.Body.Close() errcheck in keychain.go#2233

Merged
steveyegge merged 1 commit intogastownhall:mainfrom
DreadPirateRobertz:polecat/lint-errcheck-keychain
Mar 2, 2026
Merged

fix(lint): handle resp.Body.Close() errcheck in keychain.go#2233
steveyegge merged 1 commit intogastownhall:mainfrom
DreadPirateRobertz:polecat/lint-errcheck-keychain

Conversation

@DreadPirateRobertz
Copy link
Copy Markdown
Contributor

Summary

Test plan

  • go build ./cmd/gt passes
  • go vet ./internal/quota/... passes

Supersedes the remaining content of #2210 (which can be closed after this merges).

🤖 Generated with Claude Code

Wraps deferred Body.Close() to explicitly discard error, fixing errcheck
lint violation. Subsumes remaining fix from PR gastownhall#2210.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions Bot added the status/needs-triage Inbox — we haven't looked at it yet label Mar 2, 2026
@codecov-commenter
Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
7862 1 7861 35
View the top 1 failed test(s) by shortest run time
github.com/steveyegge/gastown/internal/rig::TestAddRig_UpstreamURL
Stack Traces | 0.08s run time
=== RUN   TestAddRig_UpstreamURL
    manager_test.go:1312: AddRig: Dolt server is not running (required for beads init); start it with 'gt up' or 'gt dolt start'
--- FAIL: TestAddRig_UpstreamURL (0.08s)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

DreadPirateRobertz added a commit to DreadPirateRobertz/gastown that referenced this pull request Mar 2, 2026
Wraps deferred resp.Body.Close() to explicitly discard error, fixing
errcheck lint violation. Supersedes PR gastownhall#2233.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@steveyegge steveyegge merged commit 00dc05c into gastownhall:main Mar 2, 2026
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/needs-triage Inbox — we haven't looked at it yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants