fix(lint): handle resp.Body.Close() errcheck in keychain.go#2233
Merged
steveyegge merged 1 commit intogastownhall:mainfrom Mar 2, 2026
Merged
Conversation
Wraps deferred Body.Close() to explicitly discard error, fixing errcheck lint violation. Subsumes remaining fix from PR gastownhall#2210. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
4 tasks
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
DreadPirateRobertz
added a commit
to DreadPirateRobertz/gastown
that referenced
this pull request
Mar 2, 2026
Wraps deferred resp.Body.Close() to explicitly discard error, fixing errcheck lint violation. Supersedes PR gastownhall#2233. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resp.Body.Close()to explicitly discard error, fixing errcheck lint violationTest plan
go build ./cmd/gtpassesgo vet ./internal/quota/...passesSupersedes the remaining content of #2210 (which can be closed after this merges).
🤖 Generated with Claude Code