fix: stop EnsureAllMetadata oscillating when two DBs map to same rig#3287
Merged
steveyegge merged 1 commit intogastownhall:mainfrom Mar 27, 2026
Merged
Conversation
…(gas-ar0) When routes.jsonl and rigs.json use different prefixes for the same rig (e.g. "gas-" vs "gt" for gastown), both "gastown" and "gt" Dolt databases can exist in .dolt-data/. The old code called EnsureMetadata for each one in sequence: "gastown" wrote dolt_database="gastown", then "gt" detected a mismatch and "corrected" it to "gt", printing a spurious warning. Next startup: same oscillation in reverse. Fix: group databases by rig in EnsureAllMetadata; process each rig exactly once. When multiple candidates exist, prefer whichever is already in metadata.json (if valid) to avoid repair churn. Falls back to the first candidate (alphabetical) for fresh installs. Adds TestEnsureAllMetadata_NoOscillation to prevent regression. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
❌ 5 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnsureAllMetadata— processes each rig exactly oncemetadata.jsonto avoid repair churnTestEnsureAllMetadata_NoOscillationregression testTest plan
gt upno longer prints oscillating metadata repair warnings🤖 Generated with Claude Code