sensor.proto: use NavSatSensor type#515
Merged
Merged
Conversation
Change navsat field from NavSat type to NavSatSensor type. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Member
Author
|
windows compiler warnings are pre-existing |
iche033
approved these changes
May 19, 2025
Member
Author
|
rebuilding nightly deb: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Follow-up to #476. Needed by gazebosim/gz-sim#2910.
Summary
There are separate
navsat.protoandnavsat_sensor.protomessages. All the subfields ofsensor.protouse_sensor.protomessages, except fornavsat, which I assume was a typo in #476. This changes thenavsatfield fromNavSattype toNavSatSensortype.The Migration guide doesn't need to be changed.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.