Bump gz-cmake and others in jetty by scpeters · Pull Request #2910 · gazebosim/gz-sim

scpeters · 2025-05-16T22:04:13Z

Part of gazebo-tooling/release-tools#1309.

Bumping gz-cmake and others except gz-tools. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2025-05-16T22:17:57Z

testing the full set of version bump pull requests with a custom repos file (~~gazebo-tooling/gazebodistro@a9a877d~~ ~~gazebo-tooling/gazebodistro@c5fc7c8~~ gazebo-tooling/gazebodistro@9da8b82):

* image_format -> pixel_format * gps -> navsat Signed-off-by: Steve Peters <scpeters@openrobotics.org>

This reverts commit 91cf5b8. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2025-05-18T04:23:50Z

I noticed some gz-msgs deprecation warnings and tried to naively fix them in 91cf5b8, but that didn't work, so I've reverted it for now

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2025-05-19T23:31:49Z

I noticed some gz-msgs deprecation warnings and tried to naively fix them in 91cf5b8, but that didn't work, so I've reverted it for now

I've properly fixed the pixel_format warnings in ede686b, but I believe there was a typo in gazebosim/gz-msgs#476, so I opened gazebosim/gz-msgs#515 to fix it.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters · 2025-05-20T16:29:24Z

I think the deprecation warnings and python tests are now fixed. I expect the homebrew CI to pass when it finished, but the ModelCommandAPI tests are currently failing on Ubuntu with protobuf errors (though they pass on homebrew)

libprotobuf ERROR google/protobuf/descriptor_database.cc:121] File already exists in database: gz/msgs/time.proto\n[libprotobuf

j-rivero · 2025-05-20T16:34:43Z

libprotobuf ERROR google/protobuf/descriptor_database.cc:121] File already exists in database: gz/msgs/time.proto\n[libprotobuf

I've seen these kind of messages lately in my Gazebo runs but I think that they are not critical. Looking deeper:

83: +--pose requires --model
83: +Run with --help for more information.\n
83: 
83: [  FAILED  ] ModelCommandAPI.NoServerRunning (165 ms)

Seems to a me a message coming from new standalone execs complaining about a lack of a --model flag.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

j-rivero · 2025-05-20T18:20:02Z

I've seen these kind of messages lately in my Gazebo runs but I think that they are not critical. Looking deeper:

Oh I see that the output of the command is critical for the test.

Following up on the libprotobuf ERROR google/protobuf/descriptor_database.cc:121] File already exists in database:

Lowest level minimal reproducible example I found by now is a simple run of /usr/libexec/gz/msgs12/gz-msgs. Only happens to me with the .deb gz-msgs12 nightlies. Can not reproduce it with the same code version than the nightlies in a colcon workspace. Can not find any big difference between the colcon log and the debbuilder log aside of compiler flags that being injected manually did not change the result. Something related to the nightly libgz-msgs.so.12 is making the error to appear.

j-rivero · 2025-05-20T18:36:51Z

Lowest level minimal reproducible example I found by now is a simple run of /usr/libexec/gz/msgs12/gz-msgs. Only happens to me with the .deb gz-msgs12 nightlies. Can not reproduce it with the same code version than the nightlies in a colcon workspace. Can not find any big difference between the colcon log and the debbuilder log aside of compiler flags that being injected manually did not change the result. Something related to the nightly libgz-msgs.so.12 is making the error to appear.

Ok, I get it. It has to do with the installation at the same time of the nightlies libgz-msgs11-dev and libgz-msgs12-dev. They are probably shipping the same files (since we created 12 during the transition) and something put both set of files in the protobuf knowledge by some-mechanism-vooodo. We just need to check what is still pulling the msgs11 packages into our builds and solve that.

scpeters · 2025-05-20T21:28:01Z

yeah I see that lots of Ionic packages are still being installed by our nightlies somehow

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/755/consoleText

#19 6.254 The following packages will be upgraded:
#19 6.254   gz-msgs11-cli gz-msgs12-cli gz-plugin3-cli gz-tools2 gz-transport15-cli
#19 6.254   libgz-cmake4-dev libgz-common6 libgz-common6-core-dev libgz-common6-events
#19 6.254   libgz-common6-events-dev libgz-common6-geospatial
#19 6.254   libgz-common6-geospatial-dev libgz-common6-graphics
#19 6.254   libgz-common6-graphics-dev libgz-common6-profiler libgz-common6-profiler-dev
#19 6.254   libgz-gui10 libgz-gui10-dev libgz-math8 libgz-math8-dev
#19 6.254   libgz-math8-eigen3-dev libgz-msgs11 libgz-msgs11-dev libgz-msgs12
#19 6.254   libgz-msgs12-dev libgz-physics9 libgz-physics9-bullet
#19 6.254   libgz-physics9-bullet-dev libgz-physics9-core-dev libgz-physics9-dartsim
#19 6.254   libgz-physics9-dartsim-dev libgz-physics9-dev libgz-physics9-heightmap-dev
#19 6.254   libgz-physics9-mesh-dev libgz-physics9-sdf-dev libgz-physics9-tpe
#19 6.254   libgz-physics9-tpe-dev libgz-physics9-tpelib libgz-physics9-tpelib-dev
#19 6.254   libgz-plugin3 libgz-plugin3-dev libgz-rendering9 libgz-rendering9-core-dev
#19 6.254   libgz-rendering9-ogre1 libgz-rendering9-ogre1-dev libgz-rendering9-ogre2
#19 6.254   libgz-rendering9-ogre2-dev libgz-sensors10 libgz-sensors10-air-pressure
#19 6.254   libgz-sensors10-air-pressure-dev libgz-sensors10-air-speed
#19 6.254   libgz-sensors10-air-speed-dev libgz-sensors10-altimeter
#19 6.254   libgz-sensors10-altimeter-dev libgz-sensors10-boundingbox-camera
#19 6.254   libgz-sensors10-boundingbox-camera-dev libgz-sensors10-camera
#19 6.254   libgz-sensors10-camera-dev libgz-sensors10-core-dev
#19 6.254   libgz-sensors10-depth-camera libgz-sensors10-depth-camera-dev
#19 6.254   libgz-sensors10-dev libgz-sensors10-dvl libgz-sensors10-dvl-dev
#19 6.254   libgz-sensors10-force-torque libgz-sensors10-force-torque-dev
#19 6.254   libgz-sensors10-gpu-lidar libgz-sensors10-gpu-lidar-dev libgz-sensors10-imu
#19 6.254   libgz-sensors10-imu-dev libgz-sensors10-lidar libgz-sensors10-lidar-dev
#19 6.254   libgz-sensors10-logical-camera libgz-sensors10-logical-camera-dev
#19 6.254   libgz-sensors10-magnetometer libgz-sensors10-magnetometer-dev
#19 6.254   libgz-sensors10-navsat libgz-sensors10-navsat-dev libgz-sensors10-rendering
#19 6.254   libgz-sensors10-rendering-dev libgz-sensors10-rgbd-camera
#19 6.254   libgz-sensors10-rgbd-camera-dev libgz-sensors10-segmentation-camera
#19 6.254   libgz-sensors10-segmentation-camera-dev libgz-sensors10-thermal-camera
#19 6.254   libgz-sensors10-thermal-camera-dev libgz-sensors10-wide-angle-camera
#19 6.254   libgz-sensors10-wide-angle-camera-dev libgz-tools2-dev libgz-transport15
#19 6.254   libgz-transport15-core-dev libgz-transport15-dev libgz-transport15-log
#19 6.254   libgz-transport15-log-dev libgz-transport15-parameters
#19 6.254   libgz-transport15-parameters-dev libgz-utils3 libgz-utils3-cli-dev
#19 6.254   libgz-utils3-dev libgz-utils3-log libgz-utils3-log-dev libsdformat15
#19 6.255   libsdformat15-dev python3-gz-msgs11 python3-gz-msgs12 python3-gz-transport15
#19 6.255   sdformat15-cli sdformat15-sdf

scpeters · 2025-05-20T23:30:41Z

putting the incorrect dependency versions aside, there is a repeatable test failure in the GitHub workflow:

[ RUN      ] ModelCommandAPI.NoServerRunning
  Running command [/usr/bin/gz model --list ]
  /github/workspace/src/cmd/ModelCommandAPI_TEST.cc:85: Failure
  Expected equality of these values:
    expectedOutput
      Which is: "\nService call to [/gazebo/worlds] timed out\nCommand failed when trying to get the world name of the running simulation.\n"
    output
      Which is: "--pose requires --model\nRun with --help for more information.\n"

the error message is strange because the command executed is gz model --list; neither --pose nor --model were specified. Since it passes on brew with version 2.5.0 of cli11 but fails with version 2.4.1 on 24.04, I'm wondering if it's a cli11 version issue? I'm currently testing with the vendored version of cli11 on Linux to see if that has an effect

scpeters · 2025-05-20T23:42:50Z

I'm currently testing with the vendored version of cli11 on Linux to see if that has an effect

ok, wow I just rebuilt gz-utils with -DGZ_UTILS_VENDOR_CLI11=ON, and I don't see the error message anymore

scpeters · 2025-05-20T23:49:00Z

I'm currently testing with the vendored version of cli11 on Linux to see if that has an effect

ok, wow I just rebuilt gz-utils with -DGZ_UTILS_VENDOR_CLI11=ON, and I don't see the error message anymore

one short-term option is to revert gazebosim/gz-utils#167

scpeters · 2025-05-21T03:03:32Z

I'm currently testing with the vendored version of cli11 on Linux to see if that has an effect

ok, wow I just rebuilt gz-utils with -DGZ_UTILS_VENDOR_CLI11=ON, and I don't see the error message anymore

one short-term option is to revert gazebosim/gz-utils#167

another option is to modify the debian build rules to configure with GZ_UTILS_VENDOR_CLI11=ON, which I have done in gazebo-release/gz-utils4-release#5

for testing purposes, I have built a new nightly with that branch and retriggered Ubuntu CI jobs

scpeters · 2025-05-21T04:16:50Z

another option is to modify the debian build rules to configure with GZ_UTILS_VENDOR_CLI11=ON, which I have done in gazebo-release/gz-utils4-release#5

for testing purposes, I have built a new nightly with that branch and retriggered Ubuntu CI jobs

This fixed the Ubuntu workflows, though the Jenkins job is failing; I suspect that is due to a docker cache issue

Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>

j-rivero · 2025-05-21T14:09:17Z

one short-term option is to revert gazebosim/gz-utils#167

I've committed a workaround for the problem of CLI11 in af0f309. I think that would be better than moving other pieces in releasing.

Detailed the problem in #2918

j-rivero · 2025-05-21T14:13:52Z

Running a build using gazebo-tooling/release-tools#1319 in

j-rivero · 2025-05-21T15:25:41Z

Running a build using gazebo-tooling/release-tools#1319 in

The failures related to the gz model are gone.

scpeters

one short-term option is to revert gazebosim/gz-utils#167

I've committed a workaround for the problem of CLI11 in af0f309. I think that would be better than moving other pieces in releasing.

Detailed the problem in #2918

I commented on #2918. Since gz-sim-model has been working with the vendored 1.9.1 and works with 2.5.0, this seems more like a problem with 2.4.2 to me. As I said above, I prefer restoring vendoring in gz-utils as a short-term workaround until we can merge this PR, then open a separate PR to modify gz-sim-model with af0f309. Otherwise that change to gz-sim-model will be buried in this large pull request

This reverts commit af0f309.

scpeters · 2025-05-21T17:33:13Z

I prefer restoring vendoring in gz-utils as a short-term workaround until we can merge this PR

gazebosim/gz-utils#178

scpeters · 2025-05-21T20:19:06Z

I prefer restoring vendoring in gz-utils as a short-term workaround until we can merge this PR

gazebosim/gz-utils#178

vendoring has been restored, now building a new gz-utils4 nightly deb

https://build.osrfoundation.org/job/gz-utils4-debbuilder/79/

scpeters · 2025-05-21T20:23:54Z

@osrf-jenkins run tests please

scpeters · 2025-05-21T22:23:57Z

gazebo-tooling/release-tools#1319 is merged, but it didn't seem to fix the Ubuntu jenkins build

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/765/

scpeters · 2025-05-21T22:45:53Z

gazebo-tooling/release-tools#1319 is merged, but it didn't seem to fix the Ubuntu jenkins build

there seems to be just one CI machine that is failing, so I've restarted the build on a different machine that I think will pass

iche033

looks good to me!

scpeters · 2025-05-22T03:15:10Z

building new nightly deb:

https://build.osrfoundation.org/job/gz-sim10-debbuilder/197/

j-rivero · 2025-05-22T10:19:54Z

gazebo-tooling/release-tools#1319 is merged, but it didn't seem to fix the Ubuntu jenkins build

https://build.osrfoundation.org/job/gz_sim-ci-pr_any-noble-amd64/765/

Log is:

#19 5.713 0 upgraded, 0 newly installed, 0 to remove and 153 not upgraded.
#19 5.720 Reading package lists...
#19 6.659 Building dependency tree...
#19 6.863 Reading state information...
#19 6.920 Calculating upgrade...
#19 7.228 The following packages were automatically installed and are no longer required:
#19 7.228   gz-msgs11-cli gz-plugin3-cli libgz-common6 libgz-common6-core-dev
#19 7.228   libgz-common6-events libgz-common6-events-dev libgz-common6-geospatial
#19 7.228   libgz-common6-geospatial-dev libgz-common6-graphics
#19 7.228   libgz-common6-graphics-dev libgz-common6-profiler libgz-common6-profiler-dev
#19 7.228   libgz-math8 libgz-math8-dev libgz-math8-eigen3-dev libgz-msgs11
#19 7.228   libgz-msgs11-dev libgz-plugin3 libgz-plugin3-dev libgz-rendering9
#19 7.228   libgz-rendering9-core-dev libgz-rendering9-ogre1 libgz-rendering9-ogre1-dev
#19 7.228   libgz-rendering9-ogre2 libgz-rendering9-ogre2-dev libgz-utils3
#19 7.229   libgz-utils3-cli-dev libgz-utils3-dev libgz-utils3-log libgz-utils3-log-dev
#19 7.229   libsdformat15 libsdformat15-dev python3-gz-msgs11 sdformat15-cli
#19 7.229   sdformat15-sdf
#19 7.229 Use 'apt autoremove' to remove them.

I tried to optimize running the apt-get upgrade command by running first the autoremove but it does seem to find packages to remove until apt-get upgrade is executed. Need to invert the commands gazebo-tooling/release-tools#1320

Bump gz-cmake and others in jetty

4760537

Bumping gz-cmake and others except gz-tools. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

github-actions Bot added the 🪵 jetty Gazebo Jetty label May 16, 2025

azeey added this to Core development May 16, 2025

github-project-automation Bot moved this to Inbox in Core development May 16, 2025

scpeters mentioned this pull request May 18, 2025

Remove symlink loops in engine-plugins gazebosim/gz-physics#747

Merged

8 tasks

scpeters added 2 commits May 18, 2025 03:14

Migrate from deprecated fields

91cf5b8

* image_format -> pixel_format * gps -> navsat Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Revert "Migrate from deprecated fields"

833ae6a

This reverts commit 91cf5b8. Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters marked this pull request as ready for review May 19, 2025 08:48

scpeters requested review from azeey, iche033, jennuine, mabelzhang and mjcarroll as code owners May 19, 2025 08:48

scpeters mentioned this pull request May 19, 2025

Bump in Jetty: gz-cmake and everything except gz-tools gazebo-tooling/release-tools#1309

Closed

83 tasks

Conversions: use pixel_format

ede686b

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters mentioned this pull request May 19, 2025

sensor.proto: use NavSatSensor type gazebosim/gz-msgs#515

Merged

8 tasks

scpeters added 5 commits May 19, 2025 17:26

python_system_loader: import sdformat

cd247de

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Conversions: use navsat instead of gps

9171f8c

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

SceneBroadcaster: use pixel_format

43ab5a2

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Stop using gz_test_deps

982dbed

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Remove gz_test_deps

b4a9633

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

Fix sdformat imports

b31d3b9

Signed-off-by: Steve Peters <scpeters@openrobotics.org>

scpeters mentioned this pull request May 21, 2025

Configure with GZ_UTILS_VENDOR_CLI11=ON gazebo-release/gz-utils4-release#5

Closed

j-rivero mentioned this pull request May 21, 2025

gz-sim-model is broken with 2.2.0 <= CLI11 Version < 2.5.0 (gz-sim abusing of option and flags) #2918

Closed

Workaround for problems with Ubuntu CLI11 2.4.2

af0f309

Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>

j-rivero mentioned this pull request May 21, 2025

Run apt-get autoremove in Linux builds gazebo-tooling/release-tools#1319

Merged

j-rivero mentioned this pull request May 21, 2025

Restore Stack Traces in jetty #2906

Closed

scpeters commented May 21, 2025

View reviewed changes

Comment thread src/cmd/model_main.cc Outdated

Revert "Workaround for problems with Ubuntu CLI11 2.4.2"

a967ca7

This reverts commit af0f309.

iche033 approved these changes May 22, 2025

View reviewed changes

github-project-automation Bot moved this from Inbox to In review in Core development May 22, 2025

scpeters merged commit edcbf86 into main May 22, 2025
11 checks passed

scpeters deleted the ci_matching_branch/bump_jetty_gz-sim10 branch May 22, 2025 00:35

github-project-automation Bot moved this from In review to Done in Core development May 22, 2025

j-rivero mentioned this pull request May 22, 2025

Run autoremove after dist-upgrade gazebo-tooling/release-tools#1320

Merged

scpeters mentioned this pull request May 23, 2025

gz-sim-model: workaround cli11 bug #2921

Merged

8 tasks

Uh oh!

Conversation

scpeters commented May 16, 2025

Uh oh!

scpeters commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scpeters commented May 18, 2025

Uh oh!

scpeters commented May 19, 2025

Uh oh!

scpeters commented May 20, 2025

Uh oh!

j-rivero commented May 20, 2025

Uh oh!

j-rivero commented May 20, 2025

Uh oh!

j-rivero commented May 20, 2025

Uh oh!

scpeters commented May 20, 2025

Uh oh!

scpeters commented May 20, 2025

Uh oh!

scpeters commented May 20, 2025

Uh oh!

scpeters commented May 20, 2025

Uh oh!

scpeters commented May 21, 2025

Uh oh!

scpeters commented May 21, 2025

Uh oh!

j-rivero commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j-rivero commented May 21, 2025

Uh oh!

j-rivero commented May 21, 2025

Uh oh!

scpeters left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scpeters commented May 21, 2025

Uh oh!

scpeters commented May 21, 2025

Uh oh!

scpeters commented May 21, 2025

Uh oh!

scpeters commented May 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scpeters commented May 21, 2025

Uh oh!

iche033 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scpeters commented May 22, 2025

Uh oh!

j-rivero commented May 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

scpeters commented May 16, 2025 •

edited

Loading

j-rivero commented May 21, 2025 •

edited

Loading

scpeters commented May 21, 2025 •

edited

Loading