Skip to content

Fix item visibility check when building GI Vct (backport #1216)#1222

Merged
iche033 merged 1 commit intogz-rendering10from
mergify/bp/gz-rendering10/pr-1216
Jan 9, 2026
Merged

Fix item visibility check when building GI Vct (backport #1216)#1222
iche033 merged 1 commit intogz-rendering10from
mergify/bp/gz-rendering10/pr-1216

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jan 9, 2026

🦟 Bug fix

Summary

Add better check when adding an item to the voxelizer when building GI

Previously, the objData.mOwner[k]->getVisible() check may fail and cause a crash if objData is not derived from an Ogre::Item. This PR makes sure that it's an Ogre::Item first before checking visibility.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #1216 done by [Mergify](https://mergify.com).

Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 9, 2026
@iche033 iche033 merged commit e434d98 into gz-rendering10 Jan 9, 2026
15 of 16 checks passed
@iche033 iche033 deleted the mergify/bp/gz-rendering10/pr-1216 branch January 9, 2026 22:51
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants