Skip to content

Fix item visibility check when building GI Vct#1216

Merged
iche033 merged 2 commits intomainfrom
iche033/fix_gi_vct
Jan 8, 2026
Merged

Fix item visibility check when building GI Vct#1216
iche033 merged 2 commits intomainfrom
iche033/fix_gi_vct

Conversation

@iche033
Copy link
Copy Markdown
Contributor

@iche033 iche033 commented Jan 6, 2026

🦟 Bug fix

Summary

Add better check when adding an item to the voxelizer when building GI

Previously, the objData.mOwner[k]->getVisible() check may fail and cause a crash if objData is not derived from an Ogre::Item. This PR makes sure that it's an Ogre::Item first before checking visibility.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

Signed-off-by: Ian Chen <ichen@openrobotics.org>
@codebot
Copy link
Copy Markdown

codebot commented Jan 6, 2026

Thanks @iche033 ! This fixes a crash we were seeing. 🙇

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Jan 7, 2026
@iche033 iche033 merged commit 2ca3773 into main Jan 8, 2026
13 of 14 checks passed
@iche033 iche033 deleted the iche033/fix_gi_vct branch January 8, 2026 19:32
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Jan 8, 2026
@iche033
Copy link
Copy Markdown
Contributor Author

iche033 commented Jan 9, 2026

@Mergifyio backport gz-rendering10 gz-rendering9 gz-rendering8

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 9, 2026

backport gz-rendering10 gz-rendering9 gz-rendering8

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
mergify bot pushed a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
mergify bot pushed a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
iche033 added a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
iche033 added a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
iche033 added a commit that referenced this pull request Jan 9, 2026
Signed-off-by: Ian Chen <ichen@openrobotics.org>
(cherry picked from commit 2ca3773)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants