Fix item visibility check when building GI Vct (backport #1216)#1224
Merged
iche033 merged 1 commit intogz-rendering8from Jan 9, 2026
Merged
Fix item visibility check when building GI Vct (backport #1216)#1224iche033 merged 1 commit intogz-rendering8from
iche033 merged 1 commit intogz-rendering8from
Conversation
Signed-off-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 2ca3773)
9 tasks
iche033
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Add better check when adding an item to the voxelizer when building GI
Previously, the
objData.mOwner[k]->getVisible()check may fail and cause a crash ifobjDatais not derived from anOgre::Item. This PR makes sure that it's anOgre::Itemfirst before checking visibility.Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #1216 done by [Mergify](https://mergify.com).