[fix] dvl test: check pointer in TearDown

scpeters · web-flow · commit 50db14b6f4b8 · 2026-04-16T10:18:30.000-07:00
The TearDown unconditionally dereferences the
engine pointer, which segfaults if the engine failed
to load. Check the pointer before dereferencing.

Signed-off-by: Steve Peters &lt;scpeters@openrobotics.org&gt;
diff --git a/test/integration/dvl.cc b/test/integration/dvl.cc
@@ -240,8 +240,11 @@ class DopplerVelocityLogTest : public testing::Test,
   // Documentation inherited
   protected: void TearDown() override
   {
-    engine->DestroyScene(scene);
-    rendering::unloadEngine(engine->Name());
+    if (engine)
+    {
+      engine->DestroyScene(scene);
+      rendering::unloadEngine(engine->Name());
+    }
   }
 
   rendering::RenderEngine *engine{nullptr};

Original file line number	Diff line number	Diff line change
`@@ -240,8 +240,11 @@ class DopplerVelocityLogTest : public testing::Test,`
`240`	`240`	`// Documentation inherited`
`241`	`241`	`protected: void TearDown() override`
`242`	`242`	`{`
`243`		`- engine->DestroyScene(scene);`
`244`		`- rendering::unloadEngine(engine->Name());`
	`243`	`+ if (engine)`
	`244`	`+ {`
	`245`	`+ engine->DestroyScene(scene);`
	`246`	`+ rendering::unloadEngine(engine->Name());`
	`247`	`+ }`
`245`	`248`	`}`
`246`	`249`
`247`	`250`	`rendering::RenderEngine *engine{nullptr};`