Skip to content

Fixed usd2sdf when import from model://#10

Open
ahcorde wants to merge 1 commit intomainfrom
ahcorde/fix/usd2sdf_model
Open

Fixed usd2sdf when import from model://#10
ahcorde wants to merge 1 commit intomainfrom
ahcorde/fix/usd2sdf_model

Conversation

@ahcorde
Copy link
Copy Markdown
Collaborator

@ahcorde ahcorde commented Aug 15, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

Moved from here gazebosim/sdformat#1023

Added the model:// path to the set of folder where sdf should look for models and textures

FYI @rbonghi

SDF_PATH="models" IGN_FILE_PATH="models" sdf2usd worlds/office.sdf office.usda

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Aug 15, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 15, 2022

Codecov Report

❌ Patch coverage is 5.88235% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.84%. Comparing base (157a5a1) to head (10d1792).
⚠️ Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/sdf_parser/Geometry.cc 5.88% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   65.17%   64.84%   -0.34%     
==========================================
  Files          29       29              
  Lines        2958     2975      +17     
==========================================
+ Hits         1928     1929       +1     
- Misses       1030     1046      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rbonghi
Copy link
Copy Markdown

rbonghi commented Feb 17, 2025

Hi there!
Just checking in after a while.
I was wondering if you know whether this can be rebased and possibly merged?

Best,
Raffaello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants