Fix entity type values in sim tools and docs (backport #927) - #949
Closed
mergify[bot] wants to merge 1 commit into
Closed
Fix entity type values in sim tools and docs (backport #927)#949mergify[bot] wants to merge 1 commit into
mergify[bot] wants to merge 1 commit into
Conversation
Signed-off-by: C88-YQ <1409947012@qq.com> (cherry picked from commit 2ee8a5c) # Conflicts: # ros_gz_sim/src/delete_entity.cpp # ros_gz_sim/src/set_entity_pose.cpp # ros_gz_sim/test/test_delete_entity.cpp # ros_gz_sim/test/test_set_entity_pose.cpp # ros_gz_sim_demos/README.md
Contributor
Author
|
Cherry-pick of 2ee8a5c has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Fix the entity type values used by the
delete_entityandset_entity_posetools and theros_gz_sim_demosdocumentation so they matchros_gz_interfaces/msg/Entity.msg.The previous CLI help text and README table were inconsistent with the entity type constants defined in
ros_gz_interfaces/msg/Entity.msg. This could cause users to pass the wrong entity type value when using--type.ros_gz/ros_gz_sim_demos/README.md
Lines 330 to 342 in 0ea9efc
ros_gz/ros_gz_sim/src/delete_entity.cpp
Lines 121 to 124 in 0ea9efc
ros_gz/ros_gz_sim/src/set_entity_pose.cpp
Lines 167 to 170 in 0ea9efc
ros_gz/ros_gz_interfaces/msg/Entity.msg
Lines 1 to 9 in 0ea9efc
Backport Policy
Checklist
codecheckpassed (See contributing)This is an automatic backport of pull request #927 done by [Mergify](https://mergify.com).