Make the priority flag description clearer by explicitly referring to "color IDs" instead of "colors" #595
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading the description of byte 3 in the OAM section and more precisely, the priority flag, I was confused whether the sentence
"Priority: 0 = No, 1 = BG and Window colors 1–3 are drawn over this OBJ"
was referring to colors, as in actual colors values (0: White, ...) or whether it was referring to color IDs (which might be mapped by the palette to other color values then their ID might suggest). I suppose it refers to color IDs, which is why I would make that more explicit.
If that is wrong I would suggest changing it to make it clear that color IDs are not meant and instead color values. I was not able to find a conclusive source on this.
Note that the link that is used for the color IDs is the same as used in the palettes section.