Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the priority flag description clearer by explicitly referring to "color IDs" instead of "colors" #595

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make the priority flag description clearer by explicitly referring to "color IDs" instead of "colors" #595

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/OAM.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ tile is "NN & \$FE", and the bottom 8×8 tile is "NN | \$01".
"Attributes" 7:"Priority" 6:"Y flip" 5:"X flip" 4:"DMG palette" 3:"Bank" 2-0:"CGB palette";
}}

- **Priority**: `0` = No, `1` = BG and Window colors 1–3 are drawn over this OBJ
- **Priority**: `0` = No, `1` = BG and Window [color IDs](./Tile_Data.md) 1–3 are drawn over this OBJ
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **Priority**: `0` = No, `1` = BG and Window [color IDs](./Tile_Data.md) 1–3 are drawn over this OBJ
- **Priority**: `0` = No, `1` = BG and Window [color IDs](<#Data format>) 1–3 are drawn over this OBJ

We use some custom syntax to more easily link to the appropriate section within other pages.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see, good to know :) I actually copied the link syntax from the one used in the BG palette data description, so should we also update the link there ?

- **Y flip**: `0` = Normal, `1` = Entire OBJ is vertically mirrored
- **X flip**: `0` = Normal, `1` = Entire OBJ is horizontally mirrored
- **DMG palette** *\[Non CGB Mode only\]*: `0` = OBP0, `1` = OBP1
Expand Down