Migrate to clap
#10
Merged
Migrate to clap
#10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces structopt usage with clap throughout CLI modules for argument parsing and subcommand definitions. Updates derive macros, argument attributes, and adds custom styles for improved help output. Introduces a wrapper for file uploads in dataset CLI for better parsing and cloning.
Changed the crate name from 'rust-dataverse' to 'dvcli' in Cargo.toml and removed the structopt dependency. Updated Cargo.lock to reflect the removal of structopt and related packages, as well as the new crate name.
Added Clone derivation to DataFilePath, SearchType, SortField, and Order enums to enable cloning. Migrated SearchQuery struct and related macro usage from structopt to clap for argument parsing, updating attribute macros accordingly. Removed structopt imports and replaced with clap and lazy_static where needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors the CLI subcommand definitions throughout the codebase, replacing the deprecated
structoptcrate with the modernclapcrate and its derive macros. It updates all subcommand enums to useclap::Subcommandand#[arg(...)]attributes, streamlining argument definitions and improving maintainability. Additionally, it introduces a wrapper type for file uploads in the dataset CLI to enhance type safety and parsing, and makes minor improvements to argument validation.Migration from
structopttoclap:AdminSubCommand,AuthSubCommand,CollectionSubCommand,DatasetSubCommand,FileSubCommand) now use#[derive(Subcommand, Debug)]and replace#[structopt(...)]attributes with#[arg(...)]for argument definitions, improving consistency and compatibility with the latest CLI standards. [1] [2] [3] [4] [5]structoptdependency is removed fromCargo.toml, and alluse structopt::StructOpt;imports are replaced withuse clap::Subcommand;. [1] [2] [3] [4] [5] [6]CLI argument improvements and cleanup:
required_unless_present) is updated to match the latestclapsyntax, improving error handling and user feedback.Dataset CLI enhancements:
CliUploadFileis introduced for file uploads inDatasetSubCommand, improving type safety and parsing for file arguments. The upload logic is updated to use this wrapper type. [1] [2]Other minor changes:
Cargo.tomlis changed fromrust-dataversetodvclito better reflect the CLI tool's purpose.