fix: local file:// prefix is no longer mandatory#66
Merged
eddie-knight merged 1 commit intogemaraproj:mainfrom Apr 30, 2026
Merged
fix: local file:// prefix is no longer mandatory#66eddie-knight merged 1 commit intogemaraproj:mainfrom
eddie-knight merged 1 commit intogemaraproj:mainfrom
Conversation
Signed-off-by: Eddie Knight <knight@linux.com>
hbraswelrh
approved these changes
Apr 29, 2026
hbraswelrh
left a comment
hbraswelrh
left a comment
There was a problem hiding this comment.
LGTM. Left two non-blocking nits. The comments are for consistency with the other references to TestData and testData.
| Lexicon: &gemara.ArtifactMapping{ReferenceId: "lex"}, | ||
| MappingReferences: []gemara.MappingReference{ | ||
| {Id: "lex", Title: "L", Version: "1", Url: lexiconFileURL(t, "lexicon_good.yaml")}, | ||
| {Id: "lex", Title: "L", Version: "1", Url: lexiconTestdataAbsPath(t, "lexicon_good.yaml")}, |
There was a problem hiding this comment.
Suggested change
| {Id: "lex", Title: "L", Version: "1", Url: lexiconTestdataAbsPath(t, "lexicon_good.yaml")}, | |
| {Id: "lex", Title: "L", Version: "1", Url: lexiconTestDataAbsPath(t, "lexicon_good.yaml")}, |
@eddie-knight this may be a nit, but the lexiconTestdataAbsPath is not kebab-case consistent. I'd suggest replacing with lexiconTestDataAbsPath.
There was a problem hiding this comment.
It isn't a required change. Nevermind. Testdata is considered a single word.
|
|
||
| func TestLoadLexiconFromURI_file(t *testing.T) { | ||
| entries, err := loadLexiconFromURI(context.Background(), lexiconFileURL(t, "lexicon_good.yaml")) | ||
| entries, err := loadLexiconFromURI(context.Background(), lexiconTestdataAbsPath(t, "lexicon_good.yaml")) |
There was a problem hiding this comment.
Suggested change
| entries, err := loadLexiconFromURI(context.Background(), lexiconTestdataAbsPath(t, "lexicon_good.yaml")) | |
| entries, err := loadLexiconFromURI(context.Background(), lexiconTestDataAbsPath(t, "lexicon_good.yaml")) |
Same comment for consistent kebabCase.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.