-
Notifications
You must be signed in to change notification settings - Fork 5
fix: local file:// prefix is no longer mandatory #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -269,7 +269,7 @@ func TestCatalogToMarkdown_lexiconAutolinkFromFile(t *testing.T) { | |||||
| Id: "m", Type: gemara.ControlCatalogArtifact, Description: "d", Author: gemara.Actor{Name: "a", Type: gemara.Human}, | ||||||
| Lexicon: &gemara.ArtifactMapping{ReferenceId: "lex"}, | ||||||
| MappingReferences: []gemara.MappingReference{ | ||||||
| {Id: "lex", Title: "L", Version: "1", Url: lexiconFileURL(t, "lexicon_good.yaml")}, | ||||||
| {Id: "lex", Title: "L", Version: "1", Url: lexiconTestdataAbsPath(t, "lexicon_good.yaml")}, | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
@eddie-knight this may be a nit, but the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It isn't a required change. Nevermind. Testdata is considered a single word. |
||||||
| }, | ||||||
| }, | ||||||
| Title: "Lex", | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment for consistent kebabCase.