Executor #419
Open
Executor #419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1914911059
💛 - Coveralls |
ChristianBeilschmidt
requested changes
Jan 10, 2022
# Conflicts: # services/src/error.rs
Co-authored-by: Christian Beilschmidt <[email protected]>
ChristianBeilschmidt
previously approved these changes
Jan 19, 2022
# Conflicts: # operators/src/error.rs # services/src/pro/contexts/in_memory.rs
This reverts commit fe648d3.
Restricted Hash and Eq implementation to concrete Key type
# Conflicts: # operators/src/error.rs
ChristianBeilschmidt
previously approved these changes
Jan 31, 2022
… state, i.e., only plots use the executor);
# Conflicts: # services/src/error.rs
…r FeatureCollectionRows to allow spatio-temporal filtering;
…atic result stream. This commit contains implementations for VectorQueryProcessor and RasterQueryProcessor.
# Conflicts: # services/src/error.rs
ChristianBeilschmidt
requested changes
Feb 17, 2022
There was a problem hiding this comment.
It seems to work 😄
2x NDVI Raster
2022-02-17T08:29:49.881696Z DEBUG geoengine_operators::pro::executor: Starting new computation for request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 33.75, y: 0.0 }, lower_right_coordinate: Coordinate2D { x: 45.0, y: -11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:29:49.881885Z DEBUG geoengine_operators::pro::executor: Joining running computation for request. New: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 33.75, y: 0.0 }, lower_right_coordinate: Coordinate2D { x: 45.0, y: -11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }, Running: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 33.75, y: 0.0 }, lower_right_coordinate: Coordinate2D { x: 45.0, y: -11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:29:49.884395Z DEBUG geoengine_operators::pro::executor: Computation finished. Notifying consumer streams. Request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 33.75, y: 0.0 }, lower_right_coordinate: Coordinate2D { x: 45.0, y: -11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
Raster-Vector-Join of NDVI and Natural Earth Points, then 2x Histogram:
2022-02-17T08:34:16.807763Z DEBUG geoengine_operators::pro::executor: Starting new computation for request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 45.0, y: 22.5 }, lower_right_coordinate: Coordinate2D { x: 56.25, y: 11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:34:16.809175Z DEBUG geoengine_operators::pro::executor: Stream progressed too far or results do not cover requested result. Starting new computation for request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 33.75, y: 11.25 }, lower_right_coordinate: Coordinate2D { x: 45.0, y: 0.0 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:34:16.809332Z DEBUG geoengine_operators::pro::executor: Stream progressed too far or results do not cover requested result. Starting new computation for request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 45.0, y: 45.0 }, lower_right_coordinate: Coordinate2D { x: 56.25, y: 33.75 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:34:16.809545Z DEBUG geoengine_operators::pro::executor: Stream progressed too far or results do not cover requested result. Starting new computation for request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 0.0, y: 56.25 }, lower_right_coordinate: Coordinate2D { x: 11.25, y: 45.0 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
2022-02-17T08:34:16.810209Z DEBUG geoengine_operators::pro::executor: Computation finished. Notifying consumer streams. Request: RasterTaskDescription { id: WorkflowId(8df9b0e6-e4b4-586e-90a3-6cf0f08c4e62), spatial_bounds: SpatialPartition2D { upper_left_coordinate: Coordinate2D { x: 45.0, y: 22.5 }, lower_right_coordinate: Coordinate2D { x: 56.25, y: 11.25 } }, temporal_bounds: TimeInterval [1396353600000, 1396353600000), _p: PhantomData }
Maybe we need some experiments when it joins and when this does not work. Maybe chunk sizes for vector data are too small 🤷 .
| fn slice_result(&self, result: &Self::ResultType) -> Option<Self::ResultType> { | ||
| Some(match result { | ||
| Ok(wpo) => Ok(wpo.clone()), | ||
| Err(_e) => Err(crate::error::Error::NotYetImplemented), |
There was a problem hiding this comment.
What would be necessary to do in case of an error?
There was a problem hiding this comment.
The problem here is that our Error type is not cloneable. So I cannot return the original error received from the computation.
Either we find a way to make our error cloneable (which is impossible due to wrapped errors I think), or we introduce a new error type that contains e.g, a meaningful message .
There was a problem hiding this comment.
Yeah, I guess this is a huge topic to discuss.
ChristianBeilschmidt
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first draft of the executor integration. I implemented a noop executor that is used when pro-feature is inactive.
There is a sample application in the "plots" endpoint.