Fix CoordinatePosition for Triangle #1465
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwaltersdavis
changed the title
wwaltersdavis
force-pushed
the
triangle-coordpos-fix
branch
from
1441943 to
d169585
Compare
wwaltersdavis
force-pushed
the
triangle-coordpos-fix
branch
from
d169585 to
26e5a57
Compare
michaelkirk
added a commit
that referenced
this pull request
Dec 11, 2025
Inspired by @wwaltersdavis in #1465
2 tasks
Member
|
Thanks for catching this bug! I made an alternative fix more in the spirit of the original boundary counting like we do elsewhere here: If you want the commit, feel free to implement something similar in this PR, and I'd be happy to see that merged instead. |
michaelkirk
added a commit
that referenced
this pull request
Dec 12, 2025
Inspired by @wwaltersdavis in #1465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.See #1468
Fix
boundary_countwould only go to 1).boundary_count= 1 if one is present, so if multiple are found (if a corner coord is provided) still accepted as on boundary