Fix coordinate position on vertical boundary #1475
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Inspired by @wwaltersdavis in #1465
michaelkirk
force-pushed
the
mkirk/fix-triangle-coord-pos
branch
from
3ba2724 to
0a168b3
Compare
michaelkirk
commented
Dec 12, 2025
| let orientation = T::Ker::orient2d(l.start, l.end, *coord); | ||
| if orientation == Orientation::Collinear | ||
| && point_in_rect(*coord, l.start, l.end) | ||
| && coord.x != l.end.x |
Member
Author
There was a problem hiding this comment.
Previously we were only checking the x value - but that broke down for vertical lines.
b4l
approved these changes
Dec 12, 2025
Member
b4l
left a comment
b4l
left a comment
There was a problem hiding this comment.
Thanks for fixing this edge case @michaelkirk !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGES.mdif knowledge of this change could be valuable to users.Alternative to #1465 that keeps in the spirit of boundary counting (and includes a test).