Open
Conversation
Member
Author
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
|
Container images for this PR have been built successfully!
Built from commit f3338ad |
27ca6c2 to
6b1c9e3
Compare
c11901f to
f363865
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed. |
f363865 to
055d4f0
Compare
055d4f0 to
d119f3f
Compare
728855a to
d512351
Compare
75ebd34 to
55a0f40
Compare
|
This pull request has merge conflicts. Please resolve the conflicts so the PR can stay up-to-date and reviewed. |
55a0f40 to
7c1f082
Compare
e4c9aca to
f3338ad
Compare
f3338ad to
09f0085
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Checklist
mainbranchWhat This PR Implements
Fixes: #2226
Changes Made
Testing Done
./scripts/development/dev.sh startjust lint all)just test backendAI Tool Used (if applicable)
AI Tool:
Assistance Level:
What AI helped with:
I reviewed and edited all AI-generated output:
I ran all required tests and manually verified changes:
Additional Context
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR moves swarm stack projects (saved compose configurations) under the Projects section, separating them from live/running stacks visible in the Swarm section. On the backend it adds a
swarm_stack_projectstable (with PostgreSQL and SQLite migrations), a filesystem-to-DB sync mechanism, new CRUD endpoints (/swarm/stackprojects), aDownStackendpoint that stops running services while preserving saved files, and a rename operation inUpdateStackSource. The frontend introduces new routes under/projects/swarm/*and removes the "Stacks" nav item from the Swarm section. The "Stacks" Swarm page is retained for live runtime stacks only.Confidence Score: 5/5
Safe to merge; all remaining findings are non-blocking P2 suggestions.
The core logic — migration, DB-backed sync, new CRUD endpoints, rename with rollback, DownStack — is structurally sound and well-tested. The only new finding not covered by prior comments is a P2 double-sync in GetStackProject (two full filesystem scans per request due to GetStackSource redundantly re-syncing). This is a performance inefficiency, not a correctness issue. Both previously flagged issues (TOCTOU race in upsert, $effect state update) remain open but do not block merge.
backend/internal/services/swarm_service.go (double-sync in GetStackProject / dead sync bool parameter)
Prompt To Fix All With AI
Reviews (2): Last reviewed commit: "fix: move swarm stacks to be under proje..." | Re-trigger Greptile