fix: light mode contrast for container stats CPU/memory monitor (#2341)#2344
Merged
kmendell merged 1 commit intogetarcaneapp:mainfrom Apr 11, 2026
Merged
Conversation
Member
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
kmendell
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2341 — CPU / Memory stat cards in the container logs panel were unreadable in light mode because
ContainerLogStatMonitor.svelteused hardcodedtext-white,text-white/70,text-white/55,border-white/8andbg-white/8utility classes. On a light background, white-on-white made the values, labels, detail text and the inner panel borders effectively invisible.Changes
text-foreground,text-muted-foreground)border-white/8forborder-border/60so the icon box and history chart panel border render correctly in both themesbg-white/8forbg-mutedsky-600/emerald-600,sky-500/75/emerald-500/75) plus the existingdark:variants — the 300/400 tones were too washed out against a light backgroundScope is confined to one file (
ContainerLogStatMonitor.svelte). No backend or logic changes.Test plan
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
This PR fixes a light-mode contrast bug in
ContainerLogStatMonitor.svelteby replacing hardcoded white utility classes (text-white,border-white/8,bg-white/8) with theme-aware tokens (text-foreground,text-muted-foreground,border-border/60,bg-muted) and adding explicit dark-mode variants to the tone color derivations.The change is scoped to a single file with no logic or backend changes. The Svelte runes usage (
$derived,$props) follows the project's Svelte 5 best practices, and all full Tailwind class names appear as literal strings so they will be correctly picked up by the content scanner.Confidence Score: 5/5
Safe to merge — purely visual fix with no logic, data, or backend changes.
All findings are P2 or lower. The styling substitutions are semantically correct, theme tokens are used consistently, and the Svelte reactivity patterns follow project rules. No functional regressions were identified.
No files require special attention.
Reviews (1): Last reviewed commit: "fix: light mode contrast for container s..." | Re-trigger Greptile