Skip to content

fix: light mode contrast for container stats CPU/memory monitor (#2341)#2344

Merged
kmendell merged 1 commit intogetarcaneapp:mainfrom
GiulioSavini:fix/light-mode-container-stats-contrast
Apr 11, 2026
Merged

fix: light mode contrast for container stats CPU/memory monitor (#2341)#2344
kmendell merged 1 commit intogetarcaneapp:mainfrom
GiulioSavini:fix/light-mode-container-stats-contrast

Conversation

@GiulioSavini
Copy link
Copy Markdown
Contributor

@GiulioSavini GiulioSavini commented Apr 11, 2026

Summary

Fixes #2341 — CPU / Memory stat cards in the container logs panel were unreadable in light mode because ContainerLogStatMonitor.svelte used hardcoded text-white, text-white/70, text-white/55, border-white/8 and bg-white/8 utility classes. On a light background, white-on-white made the values, labels, detail text and the inner panel borders effectively invisible.

Changes

  • Swap hardcoded white text classes for theme-aware tokens (text-foreground, text-muted-foreground)
  • Swap hardcoded border-white/8 for border-border/60 so the icon box and history chart panel border render correctly in both themes
  • Swap the disabled-bar bg-white/8 for bg-muted
  • Give the CPU/Memory tone colors a darker light-mode shade (sky-600 / emerald-600, sky-500/75 / emerald-500/75) plus the existing dark: variants — the 300/400 tones were too washed out against a light background

Scope is confined to one file (ContainerLogStatMonitor.svelte). No backend or logic changes.

Test plan

  • Open a running container → Logs tab in dark mode — CPU / Memory cards look unchanged
  • Switch profile to light mode from the sidebar — labels, values, detail and history bars are all readable with proper contrast
  • Toggle back to dark mode — visuals match baseline

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

This PR fixes a light-mode contrast bug in ContainerLogStatMonitor.svelte by replacing hardcoded white utility classes (text-white, border-white/8, bg-white/8) with theme-aware tokens (text-foreground, text-muted-foreground, border-border/60, bg-muted) and adding explicit dark-mode variants to the tone color derivations.

The change is scoped to a single file with no logic or backend changes. The Svelte runes usage ($derived, $props) follows the project's Svelte 5 best practices, and all full Tailwind class names appear as literal strings so they will be correctly picked up by the content scanner.

Confidence Score: 5/5

Safe to merge — purely visual fix with no logic, data, or backend changes.

All findings are P2 or lower. The styling substitutions are semantically correct, theme tokens are used consistently, and the Svelte reactivity patterns follow project rules. No functional regressions were identified.

No files require special attention.

Reviews (1): Last reviewed commit: "fix: light mode contrast for container s..." | Re-trigger Greptile

@kmendell
Copy link
Copy Markdown
Member

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@kmendell kmendell merged commit a1d5232 into getarcaneapp:main Apr 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Light mode container stats wrong contrast

2 participants