fix: Locale selector background was inconsistent#2348
Merged
kmendell merged 1 commit intogetarcaneapp:mainfrom Apr 11, 2026
Merged
fix: Locale selector background was inconsistent#2348kmendell merged 1 commit intogetarcaneapp:mainfrom
kmendell merged 1 commit intogetarcaneapp:mainfrom
Conversation
kmendell
approved these changes
Apr 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
mainbranchWhat This PR Implements
Fixes #2347
Removes the conflicting Tailwind class that causes the bg of the language selector to be inconsistent with the rest of the UI.
Before:


After:


Fixes:
Removed the
bg-background/50class from the Locale Picker./scripts/development/dev.sh startjust lint all)just test backendAI Tool Used (if applicable)
N/A
Disclaimer Greptiles Reviews use AI, make sure to check over its work.
To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike
To have Greptile Re-Review the changes, mention
greptileai.Greptile Summary
Removes the
bg-background/50Tailwind class from theLocalePicker'sclassprop in the appearance settings page. BecauseLocalePickerapplies the passedclassNameto its outer wrapper<div>rather than theSelect.Trigger(which already carries its ownbg-popover/90styling), the extra semi-transparent background was bleeding through and causing the visible inconsistency. The fix is minimal and correct.Confidence Score: 5/5
Safe to merge — single class removal with a clear visual improvement and no logic changes.
The change is a one-line CSS class removal that directly fixes the reported visual bug. There are no logic changes, no new dependencies, and no side effects. All remaining class attributes on the wrapper are pre-existing and unrelated to this fix.
No files require special attention.
Reviews (1): Last reviewed commit: "fix: Locale selector background was inco..." | Re-trigger Greptile
(2/5) Greptile learns from your feedback when you react with thumbs up/down!