Skip to content

fix: Locale selector background was inconsistent#2348

Merged
kmendell merged 1 commit intogetarcaneapp:mainfrom
RJMurg:fix/language-bg
Apr 11, 2026
Merged

fix: Locale selector background was inconsistent#2348
kmendell merged 1 commit intogetarcaneapp:mainfrom
RJMurg:fix/language-bg

Conversation

@RJMurg
Copy link
Copy Markdown
Contributor

@RJMurg RJMurg commented Apr 11, 2026

Checklist

  • This PR is not opened from my fork’s main branch

What This PR Implements

Fixes #2347
Removes the conflicting Tailwind class that causes the bg of the language selector to be inconsistent with the rest of the UI.

Before:
image
image

After:
image
image

Fixes:

Removed the bg-background/50 class from the Locale Picker

  • Development environment started: ./scripts/development/dev.sh start
  • Frontend verified at http://localhost:3000
  • Backend verified at http://localhost:3552
  • Manual testing completed (describe): Frontend built and background verified to be consistent
  • No linting errors (e.g., just lint all)
  • Backend tests pass: just test backend

AI Tool Used (if applicable)

N/A

Disclaimer Greptiles Reviews use AI, make sure to check over its work.

To better help train Greptile on our codebase, if the comment is useful and valid Like the comment, if its not helpful or invalid Dislike

To have Greptile Re-Review the changes, mention greptileai.

Greptile Summary

Removes the bg-background/50 Tailwind class from the LocalePicker's class prop in the appearance settings page. Because LocalePicker applies the passed className to its outer wrapper <div> rather than the Select.Trigger (which already carries its own bg-popover/90 styling), the extra semi-transparent background was bleeding through and causing the visible inconsistency. The fix is minimal and correct.

Confidence Score: 5/5

Safe to merge — single class removal with a clear visual improvement and no logic changes.

The change is a one-line CSS class removal that directly fixes the reported visual bug. There are no logic changes, no new dependencies, and no side effects. All remaining class attributes on the wrapper are pre-existing and unrelated to this fix.

No files require special attention.

Reviews (1): Last reviewed commit: "fix: Locale selector background was inco..." | Re-trigger Greptile

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

@RJMurg RJMurg requested a review from a team April 11, 2026 14:19
@kmendell kmendell merged commit a132b87 into getarcaneapp:main Apr 11, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐞 Bug: Language Preference Background is different to rest of Arcane

2 participants